Issue 22590003: input/textarea: Count value length with the standard way.

Issue 22590003: input/textarea: Count value length with the standard way. (Closed)

Created:
7 years, 4 months ago by tkent

Modified:
7 years, 4 months ago

Reviewers:
keishi

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

input/textarea: Count text length for maxLength check with the standard way. We counted use-input text in grapheme cluster unit. i.e. A letter + combining characters are counted as '1,' and a surrogate pair is counted as '1.' According to the standard and other browsers, we shoudl count them in UTF-16 code point unit. BUG=148852 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155803

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment in a test #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -39 lines)			Patch
M	LayoutTests/fast/forms/input-text-paste-maxlength.html	View		3 chunks	+16 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/forms/input-text-paste-maxlength-expected.txt	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/forms/textarea-maxlength.html	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download
M	LayoutTests/fast/forms/textarea-maxlength-expected.txt	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLTextAreaElement.cpp	View		5 chunks	+8 lines, -16 lines	0 comments	Download
M	Source/core/html/TextFieldInputType.cpp	View		3 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

keishi

lgtm https://codereview.chromium.org/22590003/diff/1/LayoutTests/fast/forms/textarea-maxlength.html File LayoutTests/fast/forms/textarea-maxlength.html (right): https://codereview.chromium.org/22590003/diff/1/LayoutTests/fast/forms/textarea-maxlength.html#newcode115 LayoutTests/fast/forms/textarea-maxlength.html:115: // However WebKit handles it as grapheme length. ...

7 years, 4 months ago (2013-08-08 06:46:51 UTC) #2

tkent

https://codereview.chromium.org/22590003/diff/1/LayoutTests/fast/forms/textarea-maxlength.html File LayoutTests/fast/forms/textarea-maxlength.html (right): https://codereview.chromium.org/22590003/diff/1/LayoutTests/fast/forms/textarea-maxlength.html#newcode115 LayoutTests/fast/forms/textarea-maxlength.html:115: // However WebKit handles it as grapheme length. On ...

7 years, 4 months ago (2013-08-08 21:07:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/22590003/8001

7 years, 4 months ago (2013-08-08 21:07:30 UTC) #4

Message was sent while issue was closed.

Change committed as 155803

Expand Messages | Collapse Messages