third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp - Issue 2258873004: Leak Detector: Count ScriptPromise and ActiveDOMObject on worker threads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp

Issue 2258873004: Leak Detector: Count ScriptPromise and ActiveDOMObject on worker threads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bug fix: Build fail on ChromeOS Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp ('k') | third_party/WebKit/Source/core/inspector/InstanceCounters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp

diff --git a/third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp b/third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp

index d84207e399f5a98c1aabecb3efd12b87b9328ed3..8c06cae54058b9f3b10d26854a5ff5cc350911d7 100644

--- a/third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp

+++ b/third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp

@@ -38,17 +38,12 @@ ActiveDOMObject::ActiveDOMObject(ExecutionContext* executionContext)

#endif

{

DCHECK(!executionContext || executionContext->isContextThread());

- // TODO(hajimehoshi): Now the leak detector can't treat vaious threads other

- // than the main thread and worker threads. After fixing the leak detector,

- // let's count objects on other threads as many as possible.

- if (isMainThread())

- InstanceCounters::incrementCounter(InstanceCounters::ActiveDOMObjectCounter);

+ InstanceCounters::incrementCounter(InstanceCounters::ActiveDOMObjectCounter);

}

ActiveDOMObject::~ActiveDOMObject()

{

- if (isMainThread())

- InstanceCounters::decrementCounter(InstanceCounters::ActiveDOMObjectCounter);

+ InstanceCounters::decrementCounter(InstanceCounters::ActiveDOMObjectCounter);

#if DCHECK_IS_ON()

DCHECK(m_suspendIfNeededCalled);