Issue 22587004: Android: wait for reboot.

Issue 22587004: Android: wait for reboot. (Closed)

Created:
7 years, 4 months ago by bulach

Modified:
7 years, 4 months ago

Reviewers:
Feng Qian, frankf, Siva Chandra

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: wait for reboot. On some devices, "reboot" is not synchronous, so the Reboot() call and its internal waits were finishing before the device had even started rebooting. BUG=265425 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216979

Patch Set 1 #

Total comments: 4

Patch Set 2 : IsOnline #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	build/android/pylib/android_commands.py	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

frankf

https://codereview.chromium.org/22587004/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/22587004/diff/1/build/android/pylib/android_commands.py#newcode363 build/android/pylib/android_commands.py:363: self.WaitForDevicePm() Doesn't WaitForDevicePm already do a 'wait-for-device'?

7 years, 4 months ago (2013-08-09 17:30:51 UTC) #4

bulach

https://codereview.chromium.org/22587004/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/22587004/diff/1/build/android/pylib/android_commands.py#newcode363 build/android/pylib/android_commands.py:363: self.WaitForDevicePm() On 2013/08/09 17:30:51, frankf wrote: > Doesn't WaitForDevicePm ...

7 years, 4 months ago (2013-08-09 17:35:44 UTC) #5

frankf

lgtm w/ nit. https://codereview.chromium.org/22587004/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/22587004/diff/1/build/android/pylib/android_commands.py#newcode355 build/android/pylib/android_commands.py:355: while retries < 10 and self._device ...

7 years, 4 months ago (2013-08-09 18:06:29 UTC) #6

bulach

thanks! addressed, CQing.. https://codereview.chromium.org/22587004/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/22587004/diff/1/build/android/pylib/android_commands.py#newcode355 build/android/pylib/android_commands.py:355: while retries < 10 and self._device ...

7 years, 4 months ago (2013-08-09 18:17:19 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/22587004/13001

7 years, 4 months ago (2013-08-09 18:18:32 UTC) #8

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=186050

7 years, 4 months ago (2013-08-10 03:15:16 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/22587004/13001

7 years, 4 months ago (2013-08-12 08:05:04 UTC) #10

Message was sent while issue was closed.

Change committed as 216979

Expand Messages | Collapse Messages