Issue 22577002: Clip region based columns properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22577002: Clip region based columns properly. (Closed)

Created:
7 years, 4 months ago by mstensho (USE GERRIT)

Modified:
7 years, 2 months ago

Reviewers:
eseidel

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Clip region based columns properly. Need to call RenderRegion::overflowRectForFlowThreadPortion() first, and THEN clip in the column gaps. overflowRectForFlowThreadPortion() expands the logical left and right to the flow thread's overflow rectangle, effectively defeating inline direction clipping completely. This patch is ported from WebKit. https://bugs.webkit.org/show_bug.cgi?id=118499 Reviewed in WebKit by David Hyatt. BUG=269441 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158387

Patch Set 1 #

Patch Set 2 : Rebase master #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+214 lines, -28 lines)			Patch
A	LayoutTests/fast/multicol/newmulticol/clipping.html	View		1 chunk	+51 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/multicol/newmulticol/clipping-expected.html	View		1 chunk	+33 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/multicol/newmulticol/clipping-overflow-hidden.html	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/multicol/newmulticol/clipping-overflow-hidden-expected.html	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/multicol/newmulticol/clipping-top-overflow.html	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/multicol/newmulticol/clipping-top-overflow-expected.html	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderMultiColumnSet.cpp	View	1	1 chunk	+14 lines, -28 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/22577002/4001

7 years, 2 months ago (2013-09-26 16:40:50 UTC) #4

Message was sent while issue was closed.

Change committed as 158387

Expand Messages | Collapse Messages