LayoutTests/fast/multicol/newmulticol/hide-box-vertical-rl-expected.html - Issue 22576002: Paint region based columns correctly in non-default writing-modes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/hide-box-vertical-rl-expected.html

Issue 22576002: Paint region based columns correctly in non-default writing-modes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Simplify comment, address code review minor issue raised with lgtm. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>hiding a box covering a multicol, vertical-rl</title>

	5 <script>

	6 if (window.internals)

	7 internals.settings.setRegionBasedColumnsEnabled(true);

	8 </script>

	9 </head>

	10 <body style="color:black; background:white;">

	11 <p>The word PASS should be seen below.</p>

	12 <div style="position:relative; width:30em; background:black;">

	13 <div style="width:20em; height:20em; -webkit-writing-mode:vertical-r l;">

	14 <div style="-webkit-logical-height:6em; line-height:2em; backgro und:cyan;">

	15 <br>

	16 <span style="-webkit-margin-start:5em;"> PASS</span>

	17 </div>

	18 </div>

	19 </div>

	20 </body>

	21 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/hide-box-vertical-rl.html ('k') | Source/core/rendering/RenderMultiColumnSet.cpp » ('j') | no next file with comments »