Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 22573005: [HTML Imports] Implement "load" and "error" events. (Closed)

Created:
7 years, 4 months ago by Hajime Morrita
Modified:
7 years, 4 months ago
Reviewers:
dglazkov, dglazkov1
CC:
blink-reviews, gavinp+prerender_chromium.org, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

[HTML Imports] Implement "load" and "error" events. To implement event delivery, this change does - Generalize HTMLLinkElement and LinkResource classes so that LinkImport class can reap the same plumblings as stylesheet link, - Introduces HTMLImportsLoaderClient, which is impleented by LinkImport, so that HTMLImportLoader notfies the readiness to its client. HTMLImportsLoader is capable to multiple client for import sharing. In such a case, multiple LinkImport objects point same loader object. In addition, this change refactors HTMLImportsController::createLoader where instance creation and reuse is now hidden in this method and callers no longer need to care about that. BUG=240592 R=dglazkov TEST=import-onload.html,import-onerror.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155818

Patch Set 1 #

Total comments: 1

Patch Set 2 : For landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -37 lines) Patch
A LayoutTests/fast/html/imports/import-onerror.html View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-onerror-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-onload.html View 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-onload-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLImportLoader.h View 3 chunks +6 lines, -1 line 0 comments Download
M Source/core/html/HTMLImportLoader.cpp View 1 3 chunks +22 lines, -3 lines 0 comments Download
A + Source/core/html/HTMLImportLoaderClient.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLImportsController.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/html/HTMLImportsController.cpp View 2 chunks +14 lines, -3 lines 0 comments Download
M Source/core/html/HTMLLinkElement.h View 3 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 2 chunks +9 lines, -3 lines 0 comments Download
M Source/core/html/LinkImport.h View 3 chunks +8 lines, -1 line 0 comments Download
M Source/core/html/LinkImport.cpp View 3 chunks +33 lines, -16 lines 0 comments Download
M Source/core/html/LinkResource.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/cache/FetchRequest.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hajime Morrita
Hi Dimitri, could you take a look?
7 years, 4 months ago (2013-08-08 10:37:42 UTC) #1
dglazkov
lgtm https://codereview.chromium.org/22573005/diff/1/Source/core/html/HTMLImportLoader.cpp File Source/core/html/HTMLImportLoader.cpp (right): https://codereview.chromium.org/22573005/diff/1/Source/core/html/HTMLImportLoader.cpp#newcode89 Source/core/html/HTMLImportLoader.cpp:89: // Since DocumentWriter::end() let setState() reenter, we shouldn't ...
7 years, 4 months ago (2013-08-08 17:04:18 UTC) #2
Hajime Morrita
Thanks for the review! I'll update the patch and land it.
7 years, 4 months ago (2013-08-09 00:37:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/22573005/7001
7 years, 4 months ago (2013-08-09 00:38:27 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-09 03:47:08 UTC) #5
Message was sent while issue was closed.
Change committed as 155818

Powered by Google App Engine
This is Rietveld 408576698