Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22573002: Add unittests for balsa classes. (Closed)

Created:
7 years, 4 months ago by yhirano
Modified:
7 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add unittests for balsa classes. Add unittests for net::BalsaFrame, net::BalsaBuffer and net::BalsaHeaders. This CL does not change any behavior. R=rch@chromium.org BUG=267354 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216572 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216948

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+994 lines, -0 lines) Patch
M net/net.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A net/tools/flip_server/balsa_frame_test.cc View 1 2 1 chunk +599 lines, -0 lines 0 comments Download
M net/tools/flip_server/balsa_headers.h View 1 chunk +1 line, -0 lines 0 comments Download
A net/tools/flip_server/balsa_headers_test.cc View 1 2 3 1 chunk +392 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yhirano
7 years, 4 months ago (2013-08-07 12:18:42 UTC) #1
Ryan Hamilton
Wow, very thorough! lgtm
7 years, 4 months ago (2013-08-07 18:32:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/22573002/3001
7 years, 4 months ago (2013-08-08 00:34:39 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=185177
7 years, 4 months ago (2013-08-08 21:21:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/22573002/3001
7 years, 4 months ago (2013-08-09 00:13:13 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-09 00:25:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/22573002/3001
7 years, 4 months ago (2013-08-09 01:14:54 UTC) #7
commit-bot: I haz the power
Change committed as 216572
7 years, 4 months ago (2013-08-09 04:18:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/22573002/52001
7 years, 4 months ago (2013-08-11 15:15:18 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 06:01:39 UTC) #10
Message was sent while issue was closed. 
Change committed as 216948

Powered by Google App Engine
This is Rietveld 408576698