Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 22571011: Remove simple_util::GetMTime from simple cache. (Closed)

Created:
7 years, 4 months ago by gavinp
Modified:
7 years, 3 months ago
Reviewers:
pasko, clamy
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Visibility:
Public.

Description

Remove simple_util::GetMTime from simple cache. With base::PlatformFile::GetPlatformFileInfo now being high resolution, there's no need for this system specific cruft in the simple disk cache. R=clamy,pasko BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220123

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -47 lines) Patch
M net/disk_cache/simple/simple_backend_impl.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M net/disk_cache/simple/simple_index_file.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download
M net/disk_cache/simple/simple_index_file_unittest.cc View 1 3 chunks +17 lines, -17 lines 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M net/disk_cache/simple/simple_util.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M net/disk_cache/simple/simple_util.cc View 1 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gavinp
This CL depends on https://codereview.chromium.org/22582009/ clamy: PTAL. pasko: FYI. Probably conflicts with a CL you're ...
7 years, 4 months ago (2013-08-07 19:13:36 UTC) #1
pasko
lgtm thanks! this seems to be an easy conflict
7 years, 4 months ago (2013-08-07 19:18:45 UTC) #2
clamy
On 2013/08/07 19:18:45, pasko wrote: > lgtm thanks! > > this seems to be an ...
7 years, 4 months ago (2013-08-08 14:42:56 UTC) #3
gavinp
I rebased this, and I'll let it bake on try before landing. This should be ...
7 years, 3 months ago (2013-08-28 17:52:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/22571011/19001
7 years, 3 months ago (2013-08-28 19:06:26 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 00:09:27 UTC) #6
Message was sent while issue was closed.
Change committed as 220123

Powered by Google App Engine
This is Rietveld 408576698