Refactoring: Get rid of isDocument() check in EventTarget.

Refactoring: Get rid of isDocument() check in EventTarget.

This is a preparation for dispatching onload events
for sub-imports.

In a coming change, newly added executingWindow() will
walk up the import tree to return the master doc's DOMWindow.

TEST=none
BUG=240592
R=abarth,dglazkov

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155921

[Hajime Morrita, 2013-08-09 09:55:46]

PTAL?

[abarth-chromium, 2013-08-09 16:25:53]

This is fine, but we'll need a different name for this function....  Is there a
defaultView() function on Document already?  Maybe window() ?

https://codereview.chromium.org/22564003/diff/1/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/22564003/diff/1/Source/core/dom/Document.h#ne...
Source/core/dom/Document.h:1032: virtual DOMWindow* browsingContext() OVERRIDE {
return domWindow(); }
This terminology doesn't match the HTML5 spec.   The term "browsing context" in
the HTML5 spec corresponds to Frame in Blink.

https://codereview.chromium.org/22564003/diff/1/Source/core/dom/EventTarget.cpp
File Source/core/dom/EventTarget.cpp (right):

https://codereview.chromium.org/22564003/diff/1/Source/core/dom/EventTarget.c...
Source/core/dom/EventTarget.cpp:275: context->userEventWasHandled();
userEventWasHandled -> didHandleUserEvent ?

[abarth-chromium, 2013-08-09 16:26:12]

LGTM, assuming you find a better name.

[Hajime Morrita, 2013-08-12 01:45:20]

Thanks for the review, Adam!

I'd pick the name "executingWindow".

The intention here, from HTML Imports pov, is to make it return the window
of mater document as imported documents don't have its own window.
defaultView() is Web-visible API and I don't want to change the behavior.

[commit-bot: I haz the power, 2013-08-12 01:47:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/22564003/9001

[commit-bot: I haz the power, 2013-08-12 03:26:23]

Change committed as 155921