Fixes vertical misalignment of IME autocompletion.

Fixes vertical misalignment of IME autocompletion.

I partially fixed vertical alignment of views::Textfield, and I'm now working on the same issue of views::Label.  However, it will take time.  So I'd like to apply this temporary fix to IME autocompletion in Omnibox.  This CL puts the Label of IME autocompletion so its baseline is aligned to Omnibox Textfield's baseline.

BUG=270442
TEST=Test manually.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217776

[Yuki, 2013-08-09 07:40:02]

Hi Peter,

Could you review this CL?

We're aiming to launch the IME autocompletion in M30, so I'd like to apply this
temporary fix in M30.

I'm now working to fix vertical alignment issues in general, but I don't think
it will be done in M30.  So we need this temporary fix.

Cheers,
Yuki Shiino

[Peter Kasting, 2013-08-09 19:00:48]

https://codereview.chromium.org/22563006/diff/1/chrome/browser/ui/views/locat...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/22563006/diff/1/chrome/browser/ui/views/locat...
chrome/browser/ui/views/location_bar/location_bar_view.cc:883: const int
baseline_diff = location_entry_view_->GetBaseline() -
Instead of doing this here, shouldn't we be doing it where the view is created
and we already give it a y offset?

Is the y offset we set there wrong due to font list differences?

[Yuki, 2013-08-12 06:30:14]

https://codereview.chromium.org/22563006/diff/1/chrome/browser/ui/views/locat...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/22563006/diff/1/chrome/browser/ui/views/locat...
chrome/browser/ui/views/location_bar/location_bar_view.cc:883: const int
baseline_diff = location_entry_view_->GetBaseline() -
On 2013/08/09 19:00:48, Peter Kasting wrote:
> Instead of doing this here, shouldn't we be doing it where the view is created
> and we already give it a y offset?
> 
> Is the y offset we set there wrong due to font list differences?

That's right.  I've moved the code to the initialization part.

And yes, because views::Label currently takes only the first font in the font
list while views::Textfield takes the whole font list, the baselines mismatch.

I'm now fixing views::Label and related code, but it will take time.  After I'll
fix it, we'll be able to pass the same FontList to
ime_inline_autocomplete_view_.

[Peter Kasting, 2013-08-12 19:54:39]

https://codereview.chromium.org/22563006/diff/6001/chrome/browser/ui/views/lo...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/22563006/diff/6001/chrome/browser/ui/views/lo...
chrome/browser/ui/views/location_bar/location_bar_view.cc:283: const int
baseline_diff = location_entry_view_->GetBaseline() -
Nit: Add comment about why this is needed and when you'll get rid of it.

https://codereview.chromium.org/22563006/diff/6001/chrome/browser/ui/views/lo...
chrome/browser/ui/views/location_bar/location_bar_view.cc:284:
ime_inline_autocomplete_view_->GetBaseline();
Nit: Indent 4, not even

https://codereview.chromium.org/22563006/diff/6001/ui/views/controls/textfiel...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://codereview.chromium.org/22563006/diff/6001/ui/views/controls/textfiel...
ui/views/controls/textfield/native_textfield_views.cc:719: return
GetRenderText()->GetBaseline();
Is it correct to make this change?  This seems wrong, and I don't think I'm the
right reviewer anyway.

[Yuki, 2013-08-13 05:51:17]

https://codereview.chromium.org/22563006/diff/6001/chrome/browser/ui/views/lo...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/22563006/diff/6001/chrome/browser/ui/views/lo...
chrome/browser/ui/views/location_bar/location_bar_view.cc:283: const int
baseline_diff = location_entry_view_->GetBaseline() -
On 2013/08/12 19:54:39, Peter Kasting wrote:
> Nit: Add comment about why this is needed and when you'll get rid of it.

Done.

https://codereview.chromium.org/22563006/diff/6001/chrome/browser/ui/views/lo...
chrome/browser/ui/views/location_bar/location_bar_view.cc:284:
ime_inline_autocomplete_view_->GetBaseline();
On 2013/08/12 19:54:39, Peter Kasting wrote:
> Nit: Indent 4, not even

Done.

https://codereview.chromium.org/22563006/diff/6001/ui/views/controls/textfiel...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://codereview.chromium.org/22563006/diff/6001/ui/views/controls/textfiel...
ui/views/controls/textfield/native_textfield_views.cc:719: return
GetRenderText()->GetBaseline();
On 2013/08/12 19:54:39, Peter Kasting wrote:
> Is it correct to make this change?  This seems wrong, and I don't think I'm
the
> right reviewer anyway.

Let me send a separate CL for this part.

If the purpose of Textfield::GetBaseline() is to get the actural baseline so we
can layout Views on the same baseline, I think this is correct.

[Peter Kasting, 2013-08-14 23:05:54]

LGTM

[commit-bot: I haz the power, 2013-08-15 05:56:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/22563006/15001

[commit-bot: I haz the power, 2013-08-15 11:16:15]

Change committed as 217776