Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 22561002: [HTML Imports] Refactoring: Split HTMLImportsController into per-class files. (Closed)

Created:
7 years, 4 months ago by Hajime Morrita
Modified:
7 years, 4 months ago
CC:
blink-reviews, gavinp+prerender_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

[HTML Imports] Refactoring: Split HTMLImportsController into per-class files. This change - Adds HTMLImportLoader.cpp/h - Adds LinkImport.cpp/h - Adds HTMLImportRoot class to abstract the controller detail away from the loader. - Turns HTMLImportLoader::create() to HTMLImportController::createLoader() to streamline the dependency. BUG=240592 R=dglazkov,dominicc TEST=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155728

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -608 lines) Patch
M Source/core/core.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLImport.h View 3 chunks +9 lines, -1 line 0 comments Download
M Source/core/html/HTMLImport.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
A + Source/core/html/HTMLImportLoader.h View 5 chunks +7 lines, -74 lines 0 comments Download
A + Source/core/html/HTMLImportLoader.cpp View 5 chunks +6 lines, -184 lines 0 comments Download
M Source/core/html/HTMLImportsController.h View 3 chunks +6 lines, -78 lines 0 comments Download
M Source/core/html/HTMLImportsController.cpp View 4 chunks +13 lines, -224 lines 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/LinkImport.h View 1 chunk +22 lines, -16 lines 0 comments Download
A + Source/core/html/LinkImport.cpp View 1 chunk +50 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hajime Morrita
PTAL?
7 years, 4 months ago (2013-08-07 09:20:48 UTC) #1
dglazkov
lgtm
7 years, 4 months ago (2013-08-07 17:26:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/22561002/1
7 years, 4 months ago (2013-08-07 23:27:06 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-07 23:52:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/22561002/1
7 years, 4 months ago (2013-08-08 01:47:43 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-08 01:51:38 UTC) #6
Message was sent while issue was closed.
Change committed as 155728

Powered by Google App Engine
This is Rietveld 408576698