Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 22555003: GCP2.0 Device: Local settings workflow. (Closed)

Created:
7 years, 4 months ago by maksymb
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

GCP2.0 Device: Local settings management. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217989

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased on InstantAuth #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -59 lines) Patch
M cloud_print/gcp20/prototype/cloud_print_requester.h View 1 2 5 chunks +25 lines, -1 line 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_requester.cc View 1 2 3 7 chunks +94 lines, -0 lines 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_response_parser.h View 1 3 chunks +11 lines, -6 lines 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_response_parser.cc View 1 1 chunk +71 lines, -0 lines 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_xmpp_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_xmpp_listener.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/gcp20/prototype/gcp20_device.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A cloud_print/gcp20/prototype/local_settings.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
M cloud_print/gcp20/prototype/printer.h View 1 2 5 chunks +25 lines, -6 lines 0 comments Download
M cloud_print/gcp20/prototype/printer.cc View 1 2 16 chunks +148 lines, -43 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
maksymb
Local Settings workflow
7 years, 4 months ago (2013-08-07 19:49:19 UTC) #1
maksymb
Please take a look at my CL
7 years, 4 months ago (2013-08-15 21:03:04 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 4 months ago (2013-08-16 04:06:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maksymb@chromium.org/22555003/31001
7 years, 4 months ago (2013-08-16 06:51:04 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 10:23:01 UTC) #5
Message was sent while issue was closed.
Change committed as 217989

Powered by Google App Engine
This is Rietveld 408576698