Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Unified Diff: chrome/browser/ui/webui/inspect_ui.cc

Issue 22536006: chrome://inspect: Better support for multiple browsers and older versions of mobile Chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/inspect/inspect.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/inspect_ui.cc
diff --git a/chrome/browser/ui/webui/inspect_ui.cc b/chrome/browser/ui/webui/inspect_ui.cc
index 430be77937c97970fcbf52d442f89b785cd8df1c..a4eaa3d336c003125cb58276932f45bc7656b216 100644
--- a/chrome/browser/ui/webui/inspect_ui.cc
+++ b/chrome/browser/ui/webui/inspect_ui.cc
@@ -92,7 +92,8 @@ static const char kFaviconUrlField[] = "faviconUrl";
static const char kPidField[] = "pid";
static const char kAdbSerialField[] = "adbSerial";
static const char kAdbModelField[] = "adbModel";
-static const char kAdbBrowserNameField[] = "adbBrowserName";
+static const char kAdbBrowserProductField[] = "adbBrowserProduct";
+static const char kAdbBrowserVersionField[] = "adbBrowserVersion";
static const char kAdbGlobalIdField[] = "adbGlobalId";
static const char kAdbBrowsersField[] = "browsers";
static const char kAdbPagesField[] = "pages";
@@ -596,12 +597,13 @@ void InspectUI::RemoteDevicesChanged(
browsers.begin(); bit != browsers.end(); ++bit) {
DevToolsAdbBridge::RemoteBrowser* browser = bit->get();
DictionaryValue* browser_data = new DictionaryValue();
- browser_data->SetString(kAdbBrowserNameField, browser->name());
+ browser_data->SetString(kAdbBrowserProductField, browser->product());
+ browser_data->SetString(kAdbBrowserVersionField, browser->version());
std::string browser_id = base::StringPrintf(
"browser:%s:%s:%s",
device->serial().c_str(),
- browser->socket().c_str(),
- browser->name().c_str());
+ browser->product().c_str(), // Force sorting by product name.
+ browser->socket().c_str());
browser_data->SetString(kAdbGlobalIdField, browser_id);
remote_browsers_[browser_id] = browser;
ListValue* page_list = new ListValue();
« no previous file with comments | « chrome/browser/resources/inspect/inspect.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698