Issue 22534003: Implements InputMethodTSF::IsCandidatePopupOpen().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22534003: Implements InputMethodTSF::IsCandidatePopupOpen(). (Closed)

Created:
7 years, 4 months ago by Yuki

Modified:
7 years, 4 months ago

Reviewers:
Seigo Nonaka, yukawa, Yohei Yukawa

CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Implements InputMethodTSF::IsCandidatePopupOpen(). This CL is almost the same as http://crrev.com/17573006, which was reverted because of a unit test breakage. BUG=245578 TEST=Test manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217091

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -7 lines)			Patch
M	ui/base/ime/input_method_tsf.h	View		3 chunks	+10 lines, -0 lines	0 comments	Download
M	ui/base/ime/input_method_tsf.cc	View		3 chunks	+36 lines, -7 lines	0 comments	Download
M	ui/base/ime/win/tsf_event_router.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/22534003/1003

7 years, 4 months ago (2013-08-12 16:16:33 UTC) #4

Message was sent while issue was closed.

Change committed as 217091