Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 22532013: Fix search-by-image regression. (Closed)

Created:
7 years, 4 months ago by Kibeom Kim (inactive)
Modified:
7 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, jingbinw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix search-by-image regression. One http request field name wasn't correct. NOTRY=true BUG=271021 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217058

Patch Set 1 #

Patch Set 2 : ++kCurrentDataVersion #

Patch Set 3 : . #

Patch Set 4 : .. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/search_engines/prepopulated_engines.json View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Kibeom Kim (inactive)
7 years, 4 months ago (2013-08-10 06:16:06 UTC) #1
Peter Kasting
You need to bump the version number.
7 years, 4 months ago (2013-08-10 07:28:14 UTC) #2
Johnny(Jianning) Ding
FYI In Google image search query, the field name "encoded_image" represents the raw image content ...
7 years, 4 months ago (2013-08-10 07:34:26 UTC) #3
Johnny(Jianning) Ding
On 2013/08/10 07:28:14, Peter Kasting wrote: > You need to bump the version number. Yes, ...
7 years, 4 months ago (2013-08-10 07:39:00 UTC) #4
Kibeom Kim (inactive)
kCurrentDataVersion from 60 to 61.
7 years, 4 months ago (2013-08-10 07:45:36 UTC) #5
Peter Kasting
LGTM
7 years, 4 months ago (2013-08-12 19:52:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/22532013/17001
7 years, 4 months ago (2013-08-12 19:59:54 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 20:02:41 UTC) #8
Message was sent while issue was closed.
Change committed as 217058

Powered by Google App Engine
This is Rietveld 408576698