Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 22528003: update examples on homepage (Closed)

Created:
7 years, 4 months ago by Kathy Walrath
Modified:
7 years, 4 months ago
Reviewers:
sethladd, mem
CC:
kasperl, mem
Base URL:
https://github.com/dart-lang/dartlang.org.git@master
Visibility:
Public.

Description

also add highlighting and tests (in new directory, where it won't bloat the site) staged at: http://fpcode.dart-lang.appspot.com/#code BUG=10797 R=sethladd@google.com Committed: 324bcf7

Patch Set 1 #

Total comments: 4

Patch Set 2 : Gentler highlighting colors #

Total comments: 4

Patch Set 3 : incorporate Seth's comments into sample code #

Patch Set 4 : tweak syntax.dart #

Patch Set 5 : Update homepage to match new samples #

Patch Set 6 : add links to more info #

Patch Set 7 : fix comment #

Total comments: 18

Patch Set 8 : incorporate most of Seth's round #2 #

Total comments: 1

Patch Set 9 : update syntax.dart #

Total comments: 2

Patch Set 10 : Split syntax into 2 tabs: Syntax & Classes #

Patch Set 11 : tweak syntax #

Patch Set 12 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -30 lines) Patch
M runtests.sh View 1 chunk +1 line, -1 line 0 comments Download
M src/site/css/style.css View 1 1 chunk +1 line, -1 line 0 comments Download
M src/site/index.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +179 lines, -27 lines 0 comments Download
M src/site/scss/style.scss View 1 1 chunk +2 lines, -1 line 0 comments Download
A src/tests/site/code/futures.dart View 1 2 3 4 5 6 7 1 chunk +14 lines, -0 lines 0 comments Download
A src/tests/site/code/syntax.dart View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +40 lines, -0 lines 0 comments Download
A src/tests/site/code/types_no.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A src/tests/site/code/types_yes.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A src/tests/site/code/webui/build.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A src/tests/site/code/webui/pubspec.yaml View 1 chunk +6 lines, -0 lines 0 comments Download
A src/tests/site/code/webui/web/webui.dart View 1 2 3 4 5 6 7 1 chunk +14 lines, -0 lines 0 comments Download
A src/tests/site/code/webui/web/webui.html View 1 2 3 4 5 6 7 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Kathy Walrath
How's this for the new code section of the homepage? http://fpcode.dart-lang.appspot.com/#code We'll need to update ...
7 years, 4 months ago (2013-08-07 23:24:35 UTC) #1
Kathy Walrath
Reload to see gentler highlighting colors. http://fpcode.dart-lang.appspot.com/#code
7 years, 4 months ago (2013-08-08 00:01:52 UTC) #2
sethladd
a few thoughts https://chromiumcodereview.appspot.com/22528003/diff/1/src/tests/site/code/futures.dart File src/tests/site/code/futures.dart (right): https://chromiumcodereview.appspot.com/22528003/diff/1/src/tests/site/code/futures.dart#newcode9 src/tests/site/code/futures.dart:9: }); how about a catchError. I ...
7 years, 4 months ago (2013-08-08 05:06:29 UTC) #3
sethladd
couple more https://chromiumcodereview.appspot.com/22528003/diff/3002/src/tests/site/code/webui/web/webui.dart File src/tests/site/code/webui/web/webui.dart (right): https://chromiumcodereview.appspot.com/22528003/diff/3002/src/tests/site/code/webui/web/webui.dart#newcode3 src/tests/site/code/webui/web/webui.dart:3: @observable String myString = ''; lets put ...
7 years, 4 months ago (2013-08-08 05:09:11 UTC) #4
Kathy Walrath
I've updated the samples (and they work) but not the homepage yet. Do these changes ...
7 years, 4 months ago (2013-08-08 17:09:38 UTC) #5
mem
lgtm On 2013/08/08 17:09:38, Kathy Walrath wrote: > I've updated the samples (and they work) ...
7 years, 4 months ago (2013-08-08 18:14:24 UTC) #6
Kathy Walrath
OK, I've updated the homepage to match the new samples and make every description link ...
7 years, 4 months ago (2013-08-08 18:52:55 UTC) #7
sethladd
Sorry for the delay, I was able to really take a look. https://chromiumcodereview.appspot.com/22528003/diff/32001/src/site/index.html File src/site/index.html ...
7 years, 4 months ago (2013-08-08 19:00:32 UTC) #8
Kathy Walrath
All incorporated except for the syntax example. That's always harder than you'd expect. I have ...
7 years, 4 months ago (2013-08-08 23:16:59 UTC) #9
Kathy Walrath
I would, of course, trim the syntax example. E.g., don't show Shape, don't show print()s, ...
7 years, 4 months ago (2013-08-08 23:23:14 UTC) #10
sethladd
https://chromiumcodereview.appspot.com/22528003/diff/32001/src/tests/site/code/syntax.dart File src/tests/site/code/syntax.dart (right): https://chromiumcodereview.appspot.com/22528003/diff/32001/src/tests/site/code/syntax.dart#newcode20 src/tests/site/code/syntax.dart:20: ..onClick.listen(startOrEndTest); should createGoldenEllipse be a named constructor? how about ...
7 years, 4 months ago (2013-08-08 23:43:11 UTC) #11
Kathy Walrath
https://chromiumcodereview.appspot.com/22528003/diff/32001/src/tests/site/code/syntax.dart File src/tests/site/code/syntax.dart (right): https://chromiumcodereview.appspot.com/22528003/diff/32001/src/tests/site/code/syntax.dart#newcode20 src/tests/site/code/syntax.dart:20: ..onClick.listen(startOrEndTest); > Your top-level function could add shapes to ...
7 years, 4 months ago (2013-08-08 23:51:59 UTC) #12
sethladd
I think it works if you leave off the generics, fwiw.
7 years, 4 months ago (2013-08-08 23:53:15 UTC) #13
Kathy Walrath
ptal
7 years, 4 months ago (2013-08-09 01:36:06 UTC) #14
sethladd
lgtm one comment. https://chromiumcodereview.appspot.com/22528003/diff/42001/src/tests/site/code/syntax.dart File src/tests/site/code/syntax.dart (right): https://chromiumcodereview.appspot.com/22528003/diff/42001/src/tests/site/code/syntax.dart#newcode4 src/tests/site/code/syntax.dart:4: var _shapes = new List(); // ...
7 years, 4 months ago (2013-08-09 01:45:22 UTC) #15
Kathy Walrath
I'm having second thoughts about the first example: I think it's too big. (The original ...
7 years, 4 months ago (2013-08-09 17:54:58 UTC) #16
Kathy Walrath
ptal https://chromiumcodereview.appspot.com/22528003/diff/42001/src/tests/site/code/syntax.dart File src/tests/site/code/syntax.dart (right): https://chromiumcodereview.appspot.com/22528003/diff/42001/src/tests/site/code/syntax.dart#newcode4 src/tests/site/code/syntax.dart:4: var _shapes = new List(); // A global ...
7 years, 4 months ago (2013-08-12 18:30:55 UTC) #17
sethladd
lgtm
7 years, 4 months ago (2013-08-12 18:34:15 UTC) #18
Kathy Walrath
7 years, 4 months ago (2013-08-12 18:38:27 UTC) #19
Message was sent while issue was closed.
Committed patchset #12 manually as r324bcf7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698