Issue 22527005: Fix pinch gestures with nonscrollable root layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22527005: Fix pinch gestures with nonscrollable root layer. (Closed)

Created:
7 years, 4 months ago by aelias_OOO_until_Jul13

Modified:
7 years, 4 months ago

Reviewers:
jamesr

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, apatrick_chromium, wjmaclean

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix pinch gestures with nonscrollable root layer. If the root scroll layer is nonscrollable (particularly when fully zoomed out on a viewport-sized page), then ScrollIgnored is returned on ScrollBegin, but we still want to support the scrolling portion of pinch gestures. Fix this by forcing CurrentlyScrollingLayer to the root layer on pinch (which is also desirable so that the scroll portion doesn't go to sublayers anyway). Secondly, always call ScrollEnd so that the pinch-set CurrentlyScrollingLayer is cleared. New test case in LayerTreeHostImplTest.PinchGesture. NOTRY=true BUG=269669 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216777

Patch Set 1 #

Patch Set 2 : Also update InputHandlerProxy tests #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -4 lines)			Patch
M	cc/trees/layer_tree_host_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/trees/layer_tree_host_impl_unittest.cc	View		11 chunks	+43 lines, -2 lines	0 comments	Download
M	content/renderer/gpu/input_handler_proxy.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/renderer/gpu/input_handler_proxy_unittest.cc	View	1	4 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/22527005/4001

7 years, 4 months ago (2013-08-09 23:28:54 UTC) #3

Message was sent while issue was closed.

Change committed as 216777

Expand Messages | Collapse Messages