Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2251343002: [Downloads] Animate the DateDividedAdapter (Closed)

Created:
4 years, 4 months ago by gone
Modified:
4 years, 4 months ago
Reviewers:
Theresa
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@DOWNLOADS_tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] Animate the DateDividedAdapter Add support for stable IDs in the DateDividedAdapter, which allows the RecyclerView to automatically determine what needs to be animated when the data set changes. The IDs for Date headers are based on the day and year of the header, while the DownloadHistoryItemWrapper combines part of the download's timestamp with its hashed GUID. BUG=616324 Committed: https://crrev.com/685ed8792c5ff5847aee0c02239aafe36a86809b Cr-Commit-Position: refs/heads/master@{#413040}

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -25 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java View 4 chunks +22 lines, -18 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java View 3 chunks +14 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/DateDividedAdapter.java View 6 chunks +34 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
gone
This builds on top of the testing CL, unfortunately, so if we want pretty animations ...
4 years, 4 months ago (2016-08-18 04:21:03 UTC) #2
gone
Swapping over...
4 years, 4 months ago (2016-08-18 19:38:49 UTC) #4
Theresa
lgtm
4 years, 4 months ago (2016-08-18 19:44:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251343002/20001
4 years, 4 months ago (2016-08-19 02:16:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 03:05:05 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 03:09:07 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/685ed8792c5ff5847aee0c02239aafe36a86809b
Cr-Commit-Position: refs/heads/master@{#413040}

Powered by Google App Engine
This is Rietveld 408576698