chrome/browser/ui/webui/inline_login_ui.cc - Issue 22510004: Show sync setup in same tab as sign in instead of active tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/inline_login_ui.cc

Issue 22510004: Show sync setup in same tab as sign in instead of active tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add web_contents parameter to ShowSyncSettingsPageInWebContents Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/inline_login_ui.cc

diff --git a/chrome/browser/ui/webui/inline_login_ui.cc b/chrome/browser/ui/webui/inline_login_ui.cc

index 967d21469da72f4a4cf32addefa0a0de83891678..da5e138f8cc811d33c8b1edde72560809b041da8 100644

--- a/chrome/browser/ui/webui/inline_login_ui.cc

+++ b/chrome/browser/ui/webui/inline_login_ui.cc

@@ -132,7 +132,7 @@ class InlineLoginUIHandler : public content::WebUIMessageHandler {

profile_, NULL, "0" /* session_index 0 for the default user */,

UTF16ToASCII(email), UTF16ToASCII(password),

OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS,

- true /* force_same_tab_navigation */,

+ web_ui()->GetWebContents(),

OneClickSigninSyncStarter::NO_CONFIRMATION,

signin::SOURCE_UNKNOWN,

OneClickSigninSyncStarter::Callback());

« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc ('k') | no next file » | no next file with comments »