EventTargets should be EventTargets

tools/dom/scripts/dartgenerator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module generates Dart APIs from the IDL database."""
 
 import emitter
 import idlnode
 import logging
@@ skipping 182 matching lines @@
           continue
         if self._database.HasInterface(parent.type.id):
           parent_interface = self._database.GetInterface(parent.type.id)
           visit(parent_interface)
       ordered.append(interface)
 
     for interface in interfaces:
       visit(interface)
     return ordered
 
+  def IsEventTarget(self, database, interface):
+    if interface.id == 'EventTarget':
+      return True
+    for parent in interface.parents:
+      parent_name = parent.type.id
+      if database.HasInterface(parent_name):
+        parent_interface = database.GetInterface(parent.type.id)
+        if self.IsEventTarget(database, parent_interface):
+          return True
+    return False
+
   def FixEventTargets(self, database):
     for interface in database.GetInterfaces():
-      # Create fake EventTarget parent interface for interfaces that have
-      # 'EventTarget' extended attribute.
-      if 'EventTarget' in interface.ext_attrs and interface.id != 'EventTarget':
+      if self.IsEventTarget(database, interface):
+        # Add as an attribute for easy querying in

[Jacob, 2013/08/08 21:15:29]

nit: make comment one line

+        # generation code.
+        interface.ext_attrs['EventTarget'] = None
+      elif 'EventTarget' in interface.ext_attrs:
+        # Create fake EventTarget parent interface for interfaces that have
+        # 'EventTarget' extended attribute.
         ast = [('Annotation', [('Id', 'WebKit')]),
                ('InterfaceType', ('ScopedName', 'EventTarget'))]
         interface.parents.append(idlnode.IDLParentInterface(ast))
 
   def AddMissingArguments(self, database):
     ARG = idlnode.IDLArgument([('Type', ('ScopedName', 'object')), ('Id', 'arg')])
     for interface in database.GetInterfaces():
       for operation in interface.operations:
         call_with = (operation.ext_attrs.get('CallWith', '').split('|') +
                      operation.ext_attrs.get('ConstructorCallWith', '').split('|') +
                      operation.ext_attrs.get('CallWith', '').split('&') +
                      operation.ext_attrs.get('ConstructorCallWith', '').split('&'))
         if 'ScriptArguments' in call_with:
           operation.arguments.append(ARG)