Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1431)

Unified Diff: components/data_reduction_proxy/content/browser/content_lofi_ui_service.h

Issue 2250223002: Add InfoBar delegate for previews (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: missed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/content/browser/content_lofi_ui_service.h
diff --git a/components/data_reduction_proxy/content/browser/content_lofi_ui_service.h b/components/data_reduction_proxy/content/browser/content_lofi_ui_service.h
index 34757cb3e138536819d198e79c797e885b98196f..09ec62a5b5d4052c6e8b570f2a637036c4d829f2 100644
--- a/components/data_reduction_proxy/content/browser/content_lofi_ui_service.h
+++ b/components/data_reduction_proxy/content/browser/content_lofi_ui_service.h
@@ -24,8 +24,8 @@ class URLRequest;
namespace data_reduction_proxy {
-typedef base::Callback<void(content::WebContents* web_contents,
- bool is_preview)> OnLoFiResponseReceivedCallback;
+typedef base::Callback<void(content::WebContents* web_contents)>
+ OnLoFiResponseReceivedCallback;
Peter Kasting 2016/08/24 21:58:00 Nit: Prefer type aliases (with "using") to typedef
megjablon 2016/08/24 22:23:43 Done.
// Passes notifications to the UI thread that a Lo-Fi response has been
// received. These notifications may be used to show Lo-Fi UI. This object lives
@@ -38,8 +38,7 @@ class ContentLoFiUIService : public LoFiUIService {
~ContentLoFiUIService() override;
// LoFiUIService implementation:
- void OnLoFiReponseReceived(const net::URLRequest& request,
- bool is_preview) override;
+ void OnLoFiReponseReceived(const net::URLRequest& request) override;
private:
// Using the |render_process_id| and |render_frame_id|, gets the associated
@@ -47,8 +46,7 @@ class ContentLoFiUIService : public LoFiUIService {
// |notify_lofi_response_received_callback_|. |is_preview| indicates whether
// the response was a Lo-Fi preview response.
void OnLoFiResponseReceivedOnUIThread(int render_process_id,
- int render_frame_id,
- bool is_preview);
+ int render_frame_id);
// A task runner to post calls to OnLoFiReponseReceivedOnUI on the UI
// thread.

Powered by Google App Engine
This is Rietveld 408576698