Add InfoBar delegate for previews

chrome/browser/previews/previews_infobar_delegate.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREVIEWS_PREVIEWS_INFOBAR_DELEGATE_H_
+#define CHROME_BROWSER_PREVIEWS_PREVIEWS_INFOBAR_DELEGATE_H_
+
+#include "base/macros.h"
+#include "base/strings/string16.h"
+#include "components/infobars/core/confirm_infobar_delegate.h"

[Peter Kasting, 2016/08/23 19:48:18]

This is the only #include we actually need.

Even if you wanted to do strict IWYU, we wouldn't need infobar_delegate.h,
because we don't ever refer to its contents.  But Chromium code doesn't
generally do IWYU.

[megjablon, 2016/08/23 23:54:18]

Kept macros because it's used by DISALLOW_COPY_AND_ASSIGN

[Peter Kasting, 2016/08/24 03:18:27]

Sure, but confirm_infobar_delegate.h pulls that in too.

It's not a big deal, especially when it's macros.h and your list is two items
long anyway.  I just feel weird being in a place where we're not quite "minimum
includes possible" and not quite "IWYU".

[megjablon, 2016/08/24 21:44:31]

Done.

+#include "components/infobars/core/infobar_delegate.h"
+
+namespace content {
+class WebContents;
+}  // namespace content

[Peter Kasting, 2016/08/23 19:48:18]

Nit: I'd omit the trailing comment here; you omitted it below, and on these
short forward-decl blocks, it's just noise.

[megjablon, 2016/08/23 23:54:18]

Done.

+
+namespace data_reduction_proxy {
+class DataReductionProxySettings;
+}
+
+class PreviewsInfoBarDelegate : public ConfirmInfoBarDelegate {
+ public:
+  // The type of the infobar. It controls the strings and records UMA for the

[Peter Kasting, 2016/08/23 19:48:18]

Nit: An enum can't "record UMA"; do you mean "and what UMA data is recorded for
the infobar"? (2 places)

[megjablon, 2016/08/23 23:54:18]

Done.

[Peter Kasting, 2016/08/24 03:18:27]

Consider also updating the comment on Create() that has similar text.

[megjablon, 2016/08/24 21:44:30]

Done.

+  // type.
+  enum PreviewsInfoBarType {
+    LOFI,

[Peter Kasting, 2016/08/23 19:48:18]

Nit: Consider explaining what these types mean.

[megjablon, 2016/08/23 23:54:17]

Done.

+    PREVIEW, // TODO(megjablon): Rename all references to server side previews
+    OFFLINE,
+  };
+
+  // Creates a preview infobar and corresponding delegate and adds the infobar
+  // to InfoBarService. |infobar_type| controls the strings and records UMA for
+  // the type.
+  static void Create(content::WebContents* web_contents,
+                     PreviewsInfoBarType infobar_type);
+
+  ~PreviewsInfoBarDelegate() override;

[Peter Kasting, 2016/08/23 19:48:18]

Nit: Per Google style guide, destructor goes above static methods

[megjablon, 2016/08/23 23:54:18]

Done.

+
+  void RemoveInfoBar();
+
+ private:
+  class PreviewInfoBarWebContentsObserver;
+
+  PreviewsInfoBarDelegate(content::WebContents* web_contents,
+                          PreviewsInfoBarType infobar_type);
+
+  // InfoBarDelegate overrides:
+  bool ShouldExpire(const NavigationDetails& details) const override;
+
+  // ConfirmInfoBarDelegate overrides:
+  infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;
+  int GetIconId() const override;
+  base::string16 GetMessageText() const override;
+  int GetButtons() const override;
+  base::string16 GetLinkText() const override;
+  bool LinkClicked(WindowOpenDisposition disposition) override;
+
+  std::unique_ptr<PreviewInfoBarWebContentsObserver> web_contents_observer_;
+  PreviewsInfoBarType infobar_type_;
+
+  DISALLOW_COPY_AND_ASSIGN(PreviewsInfoBarDelegate);
+};
+
+#endif  // CHROME_BROWSER_PREVIEWS_PREVIEWS_INFOBAR_DELEGATE_H_