Issue 22500003: Fix canvas drawSystemFocusRing in focus event handler.

Issue 22500003: Fix canvas drawSystemFocusRing in focus event handler. (Closed)

Created:
7 years, 4 months ago by dmazzoni

Modified:
7 years, 4 months ago

Reviewers:
Stephen White

CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix canvas drawSystemFocusRing in focus event handler. BUG=261998 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155699

Patch Set 1 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -13 lines)			Patch
A +	LayoutTests/fast/canvas/draw-system-focus-ring-on-event.html	View	1 chunk	+16 lines, -13 lines	2 comments	Download
A +	LayoutTests/fast/canvas/draw-system-focus-ring-on-event-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.cpp	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Stephen White

LGTM https://codereview.chromium.org/22500003/diff/1/LayoutTests/fast/canvas/draw-system-focus-ring-on-event.html File LayoutTests/fast/canvas/draw-system-focus-ring-on-event.html (right): https://codereview.chromium.org/22500003/diff/1/LayoutTests/fast/canvas/draw-system-focus-ring-on-event.html#newcode18 LayoutTests/fast/canvas/draw-system-focus-ring-on-event.html:18: canvas.beginPath(); FYI, you can use fillRect() as a ...

7 years, 4 months ago (2013-08-07 14:00:26 UTC) #2

dmazzoni

https://codereview.chromium.org/22500003/diff/1/LayoutTests/fast/canvas/draw-system-focus-ring-on-event.html File LayoutTests/fast/canvas/draw-system-focus-ring-on-event.html (right): https://codereview.chromium.org/22500003/diff/1/LayoutTests/fast/canvas/draw-system-focus-ring-on-event.html#newcode18 LayoutTests/fast/canvas/draw-system-focus-ring-on-event.html:18: canvas.beginPath(); On 2013/08/07 14:00:26, Stephen White wrote: > FYI, ...

7 years, 4 months ago (2013-08-07 15:42:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/22500003/1

7 years, 4 months ago (2013-08-07 15:42:44 UTC) #4

Stephen White

On 2013/08/07 15:42:29, Dominic Mazzoni wrote: > https://codereview.chromium.org/22500003/diff/1/LayoutTests/fast/canvas/draw-system-focus-ring-on-event.html > File LayoutTests/fast/canvas/draw-system-focus-ring-on-event.html (right): > > https://codereview.chromium.org/22500003/diff/1/LayoutTests/fast/canvas/draw-system-focus-ring-on-event.html#newcode18 ...

7 years, 4 months ago (2013-08-07 15:44:54 UTC) #5

Message was sent while issue was closed.

Change committed as 155699

Expand Messages | Collapse Messages