Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22493014: Change from DCHECK to conditional to prevent false alarm on shelf alignment changed. (Closed)

Created:
7 years, 4 months ago by Harry McCleave
Modified:
7 years, 4 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Change from DCHECK to conditional to prevent false alarm on shelf alignment changed. BUG= TBR=jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M ash/launcher/launcher_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Harry McCleave
.
7 years, 4 months ago (2013-08-09 20:36:49 UTC) #1
Mr4D (OOO till 08-26)
lgtm
7 years, 4 months ago (2013-08-09 20:38:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/22493014/1
7 years, 4 months ago (2013-08-09 20:42:33 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-10 14:59:31 UTC) #4
Message was sent while issue was closed. 
Change committed as 216858

Powered by Google App Engine
This is Rietveld 408576698