Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: tools/perf/metrics/histogram.py

Issue 22492004: Move memory-related histogram data collection to metrics/memory.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor change (to make what is happening more explicit) Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/metrics/memory.py » ('j') | tools/perf/metrics/memory.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/histogram.py
diff --git a/tools/perf/metrics/histogram.py b/tools/perf/metrics/histogram.py
index 6a45b1cb3cd29de8a99e9b974dd10ba77d8cf2d4..6711fb179a35093e715b1c6021942fe92d80cb88 100644
--- a/tools/perf/metrics/histogram.py
+++ b/tools/perf/metrics/histogram.py
@@ -25,12 +25,14 @@ def GetHistogramData(histogram_type, histogram_name, tab):
function = 'getBrowserHistogram'
# TODO(jeremy): Remove references to
# domAutomationController when we update the reference builds.
- return tab.EvaluateJavaScript(
+ histogram_json = tab.EvaluateJavaScript(
'(window.statsCollectionController ? '
'statsCollectionController : '
'domAutomationController).%s("%s")' %
(function, histogram_name))
-
+ if histogram_json:
+ return histogram_json
+ return None
def SubtractHistogram(histogram_json, start_histogram_json):
"""Subtracts a previous histogram from a histogram.
« no previous file with comments | « no previous file | tools/perf/metrics/memory.py » ('j') | tools/perf/metrics/memory.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698