Issue 22484002: Mozilla diabolical clamp case added to gm/gradients.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22484002: Mozilla diabolical clamp case added to gm/gradients.cpp (Closed)

Created:
7 years, 4 months ago by dierk

Modified:
7 years, 4 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Mozilla diabolical clamp case added to gm/gradients.cpp Added diabolical clamp case. BUG= Committed: http://code.google.com/p/skia/source/detail?r=10604

Patch Set 2 : Added scaling to matrix to show clamp error. #

Total comments: 1

Patch Set 3 : nit from Mike #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	gm/gradients.cpp	View	1 2	3 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

reed1

lgtm w/ nit https://codereview.chromium.org/22484002/diff/3001/gm/gradients.cpp File gm/gradients.cpp (right): https://codereview.chromium.org/22484002/diff/3001/gm/gradients.cpp#newcode133 gm/gradients.cpp:133: scale.setTranslateX(25.f); nit: more natural (perhaps) to ...

7 years, 4 months ago (2013-08-06 21:19:17 UTC) #2

reed1

since this is a mod to an existing gm... you'll have to play the rebaseline ...

7 years, 4 months ago (2013-08-06 21:19:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dierk@google.com/22484002/9001

7 years, 4 months ago (2013-08-07 15:05:18 UTC) #4

Message was sent while issue was closed.

Change committed as 10604