Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 2248103002: Reland: Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Properly handle incognito browsing Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
index 520c8bf7caf068c7d79b363429a4e8f828a17b7e..cee60ab4191b23ae4ac1827f3593e009bd6e77ba 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
@@ -1776,8 +1776,9 @@ void BookmarkBarView::ConfigureButton(const BookmarkNode* node,
button->set_id(VIEW_ID_BOOKMARK_BAR_ELEMENT);
// We don't always have a theme provider (ui tests, for example).
if (GetThemeProvider()) {
- SkColor color =
- GetThemeProvider()->GetColor(ThemeProperties::COLOR_BOOKMARK_TEXT);
+ SkColor color = GetThemeProvider()->GetColor(
+ IsDetached() ? ThemeProperties::COLOR_NTP_TEXT
+ : ThemeProperties::COLOR_BOOKMARK_TEXT);
button->SetEnabledTextColors(color);
if (node->is_folder()) {
button->SetImage(views::Button::STATE_NORMAL,
@@ -2102,8 +2103,9 @@ void BookmarkBarView::UpdateAppearanceForTheme() {
const ui::ThemeProvider* theme_provider = GetThemeProvider();
if (!theme_provider)
return;
- SkColor color =
- theme_provider->GetColor(ThemeProperties::COLOR_BOOKMARK_TEXT);
+ SkColor color = theme_provider->GetColor(
+ IsDetached() ? ThemeProperties::COLOR_NTP_TEXT
+ : ThemeProperties::COLOR_BOOKMARK_TEXT);
for (int i = 0; i < GetBookmarkButtonCount(); ++i) {
ConfigureButton(model_->bookmark_bar_node()->GetChild(i),
GetBookmarkButton(i));

Powered by Google App Engine
This is Rietveld 408576698