Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/test/mini_installer/verifier.py

Issue 22480002: Use unittest framework in the Automated Installer Testing Framework. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address mathp's comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import registry_verifier 5 import registry_verifier
6 6
7
7 def Verify(property): 8 def Verify(property):
8 """Verifies that the current machine states match the property object.""" 9 """Verifies that the current machine states match the property dictionary.
10
11 Args:
12 property: A property dictionary.
Mathieu 2013/08/12 17:37:26 can you describe what is a value in this dictionar
sukolsak 2013/08/12 19:20:20 Done.
13 """
9 for verifier_name, value in property.iteritems(): 14 for verifier_name, value in property.iteritems():
Mathieu 2013/08/12 17:37:26 perhaps rename value -> entries to be more consist
sukolsak 2013/08/12 19:20:20 Other verifiers that I am going to add will have d
10 if verifier_name == 'RegistryEntries': 15 if verifier_name == 'RegistryEntries':
11 registry_verifier.VerifyRegistryEntries(value) 16 registry_verifier.VerifyRegistryEntries(value)
12 else: 17 else:
13 # TODO(sukolsak): Implement other verifiers 18 # TODO(sukolsak): Implement other verifiers
14 # TODO(sukolsak): Use unittest framework instead of exceptions. 19 raise KeyError('Unknown verifier %s' % verifier_name)
15 raise Exception('Unknown verifier')
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698