telemetry: separated stats collection from metrics calculation.

telemetry: separated stats collection from metrics calculation.

- Split calculation of smoothness metrics into two parts:
  A) collection of stats (now from RenderingStats, in the future
  from traces),
  B) calculation of the actual benchmark metrics from the stats.
- This allows modifying and testing both parts independently

R=nduca@chromium.org
BUG=264308
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216832

[tonyg, 2013-08-09 22:38:32]

We'll need to reconcile this and https://codereview.chromium.org/22428004/

[nduca, 2013-08-09 22:38:57]

minor tweak suggested but lgtm

https://codereview.chromium.org/22475007/diff/1/tools/perf/metrics/benchmark_...
File tools/perf/metrics/benchmark_stats.py (right):

https://codereview.chromium.org/22475007/diff/1/tools/perf/metrics/benchmark_...
tools/perf/metrics/benchmark_stats.py:5: def
MakeBenchmarkStats(rendering_stats_deltas):
How about you make this be a class  with fields.
  self.total_time = rs.blahbllah

and this function is the __init__(...)

Maybe anotehr name too, like GpuRenderingStats?

[ernstm, 2013-08-09 23:37:31]

https://codereview.chromium.org/22475007/diff/1/tools/perf/metrics/benchmark_...
File tools/perf/metrics/benchmark_stats.py (right):

https://codereview.chromium.org/22475007/diff/1/tools/perf/metrics/benchmark_...
tools/perf/metrics/benchmark_stats.py:5: def
MakeBenchmarkStats(rendering_stats_deltas):
On 2013/08/09 22:38:57, nduca wrote:
> How about you make this be a class  with fields.
>   self.total_time = rs.blahbllah
> 
> and this function is the __init__(...)
> 
> Maybe anotehr name too, like GpuRenderingStats?

Done.

[nduca, 2013-08-09 23:40:03]

beautiful. lgtm

[ernstm, 2013-08-09 23:47:56]

On 2013/08/09 22:38:32, tonyg wrote:
> We'll need to reconcile this and https://codereview.chromium.org/22428004/

I synced with qyearsley@ and we decided to commit this patch first.
https://codereview.chromium.org/22428004/ might not be required after that.

[commit-bot: I haz the power, 2013-08-09 23:49:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernstm@chromium.org/22475007/7001

[commit-bot: I haz the power, 2013-08-10 08:33:34]

Change committed as 216832