Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 22474007: Revert "mod does not rely on a fixed register anymore, the arguments are passed via the stack." (Closed)

Created:
7 years, 4 months ago by Toon Verwaest
Modified:
7 years, 4 months ago
Reviewers:
oliv, danno
CC:
v8-dev
Visibility:
Public.

Description

Revert "mod does not rely on a fixed register anymore, the arguments are passed via the stack." Due to buildbot failures. BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/ia32/lithium-ia32.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 4 months ago (2013-08-07 17:11:03 UTC) #1
danno
lgtm
7 years, 4 months ago (2013-08-07 17:21:46 UTC) #2
Toon Verwaest
7 years, 4 months ago (2013-08-07 17:22:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16110 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698