Refactor stages 1, 2 and test_api overhaul.

scripts/slave/recipe_modules/chromium_tests/steps.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import json
 import re
 import string
 
 
@@ skipping 1405 matching lines @@
           self._run_results, self.retcodes, self.test_config)
       api.bisect_tester.upload_results(self.test_output, self.values,
                                        self.retcodes, self._test_parameters)
 
   def has_valid_results(self, *_):
     return len(getattr(self, 'values', [])) > 0  # pragma: no cover
 
   def failures(self, *_):
     return self._failures  # pragma: no cover
 
-class BisectTestStaging(BisectTest):
+
+class BisectTestStaging(Test):  # pylint: disable=W0232
+  name = 'bisect_test_staging'
+
+  def __init__(self, test_parameters={}, **kwargs):
+    super(BisectTestStaging, self).__init__()
+    self._test_parameters = test_parameters
+    self.run_results = {}
+    self.kwargs = kwargs
+
+  @property
+  def abort_on_failure(self):
+    return True  # pragma: no cover
+
+  @property
+  def uses_local_devices(self):
+    return False
+
+  @staticmethod
+  def compile_targets(_):  # pragma: no cover
+    return ['chrome'] # Bisect always uses a separate bot for building.
+
   def pre_run(self, api, _, test_filter=None):
     self.test_config = api.bisect_tester_staging.load_config_from_dict(
         self._test_parameters.get('bisect_config',
                                   api.properties.get('bisect_config')))
 
   def run(self, api, _, test_filter=None):
-    self._run_results, self.test_output, self.retcodes = (
-        api.bisect_tester_staging.run_test(self.test_config))
+    self.run_results = api.bisect_tester_staging.run_test(
+        self.test_config, **self.kwargs)
 
-  def post_run(self, api, _, test_filter=None):
-      self.values = api.bisect_tester_staging.digest_run_results(
-          self._run_results, self.retcodes, self.test_config)
-      api.bisect_tester_staging.upload_results(
-          self.test_output, self.values, self.retcodes, self._test_parameters)
+  def has_valid_results(self, *_):
+    return bool(self.run_results.get('retcodes')) # pragma: no cover
+
+  def failures(self, *_):
+    return self._failures  # pragma: no cover
 
 
 class AndroidTest(Test):
   def __init__(self, name, compile_targets, isolate_file_path=None):
     super(AndroidTest, self).__init__()
 
     self._name = name
     self._compile_targets = compile_targets
 
     self.isolate_file_path = isolate_file_path
@@ skipping 413 matching lines @@
           args=args)
       api.gsutil.upload(
           temp_output_dir.join(
               '%s-android-chrome.json' % timestamp_string),
           'chromium-annotated-tests', 'android')
 
 GOMA_TESTS = [
   GTestTest('base_unittests'),
   GTestTest('content_unittests'),
 ]