Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2306)

Unified Diff: apps/shell/test/shell_test.cc

Issue 224723022: Add the first app_shell_browsertest test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: temp dep Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/shell/test/shell_test.h ('k') | apps/shell/test/shell_test_launcher_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/shell/test/shell_test.cc
diff --git a/apps/test/app_shell_test.cc b/apps/shell/test/shell_test.cc
similarity index 69%
rename from apps/test/app_shell_test.cc
rename to apps/shell/test/shell_test.cc
index 683bdddd40ca0b4cba29a981edc150201c9c5631..3d2cfeec0daa0bf37f647d6b85050fb5b34b4058 100644
--- a/apps/test/app_shell_test.cc
+++ b/apps/shell/test/shell_test.cc
@@ -2,12 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "apps/test/app_shell_test.h"
+#include "apps/shell/test/shell_test.h"
#include "apps/shell/browser/shell_content_browser_client.h"
+#include "apps/shell/browser/shell_desktop_controller.h"
#include "apps/shell/browser/shell_extension_system.h"
+#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/logging.h"
+#include "content/public/common/content_switches.h"
#include "extensions/browser/extension_system.h"
namespace apps {
@@ -17,6 +20,12 @@ AppShellTest::AppShellTest()
AppShellTest::~AppShellTest() {}
+void AppShellTest::SetUp() {
+ base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
+ command_line->AppendSwitchASCII(switches::kTestType, "appshell");
+ content::BrowserTestBase::SetUp();
+}
+
void AppShellTest::SetUpOnMainThread() {
browser_context_ = ShellContentBrowserClient::Get()->GetBrowserContext();
@@ -25,7 +34,6 @@ void AppShellTest::SetUpOnMainThread() {
}
void AppShellTest::RunTestOnMainThreadLoop() {
- // Pump startup related events.
base::MessageLoopForUI::current()->RunUntilIdle();
SetUpOnMainThread();
@@ -33,6 +41,9 @@ void AppShellTest::RunTestOnMainThreadLoop() {
RunTestOnMainThread();
TearDownOnMainThread();
+
+ // Clean up the app window.
+ ShellDesktopController::instance()->CloseAppWindow();
}
bool AppShellTest::LoadAndLaunchApp(const base::FilePath& app_dir) {
« no previous file with comments | « apps/shell/test/shell_test.h ('k') | apps/shell/test/shell_test_launcher_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698