Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: Source/bindings/v8/ScriptFunction.h

Issue 22470008: Implement ScriptPromise and ScriptFunction (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Protect the ScriptFunction with a strong ref Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 10 matching lines...) Expand all
21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef LayerRect_h 31 #ifndef ScriptFunction_h
32 #define LayerRect_h 32 #define ScriptFunction_h
33 33
34 #include "core/dom/ClientRect.h" 34 #include "bindings/v8/GarbageCollected.h"
35 35 #include "bindings/v8/ScriptValue.h"
36 #include "wtf/PassRefPtr.h" 36 #include "bindings/v8/V8Binding.h"
37 #include "wtf/RefCounted.h" 37 #include "wtf/RefCounted.h"
38 #include "wtf/RefPtr.h" 38 #include <v8.h>
39 39
40 namespace WebCore { 40 namespace WebCore {
41 41
42 class Node; 42 // This class allows C++ to be passed as a v8::Function. To use it:
43 // 1. Inherit from ScriptFunction and override call().
44 // 2. toV8() will return a v8::Function that, when called, will call
45 // the overridden call() method.
46 //
47 // This exists primarily to support ScriptPromise::then().
48 class ScriptFunction : public RefCounted<ScriptFunction> {
49 public:
50 ScriptFunction() { }
43 51
44 class LayerRect : public RefCounted<LayerRect> { 52 // override this
45 public: 53 virtual ScriptValue call(ScriptValue arg) { return ScriptValue(); }
46 static PassRefPtr<LayerRect> create(PassRefPtr<Node> node, PassRefPtr<Client Rect> rect) 54
55 v8::Handle<v8::Function> toV8()
47 { 56 {
48 return adoptRef(new LayerRect(node, rect)); 57 v8::Isolate* isolate = v8::Isolate::GetCurrent();
58 if (m_function.isEmpty()) {
59 ref();
abarth-chromium 2013/08/15 00:23:54 You should be able to encapsulate all this nastine
60 m_function.set(isolate, v8::FunctionTemplate::New(&callCallback, v8: :External::New(this))->GetFunction());
61 }
62 return m_function.newLocal(isolate);
49 } 63 }
50 64
51 Node* layerRootNode() const { return m_layerRootNode.get(); } 65 protected:
52 ClientRect* layerRelativeRect() const { return m_rect.get(); } 66 virtual ~ScriptFunction() { }
53 67
54 private: 68 private:
55 LayerRect(PassRefPtr<Node> node, PassRefPtr<ClientRect> rect) 69 static void callCallback(const v8::FunctionCallbackInfo<v8::Value>& args)
56 : m_layerRootNode(node)
57 , m_rect(rect)
58 { 70 {
71 v8::Isolate* isolate = args.GetIsolate();
72 ASSERT(!args.Data().IsEmpty());
73 RefPtr<ScriptFunction> function = adoptRef(static_cast<ScriptFunction*>( args.Data().As<v8::External>()->Value()));
74 v8::Local<v8::Value> value = args.Length() > 0 ? (args[0]) : v8::Local<v 8::Value>(v8::Undefined(isolate));
75
76 ScriptValue result = function->call(ScriptValue(value));
77 v8SetReturnValue(args, result.v8Value());
59 } 78 }
60 79
61 RefPtr<Node> m_layerRootNode; 80 GarbageCollected<v8::Function> m_function;
abarth-chromium 2013/08/15 00:35:15 ScriptFunction need to hold a ScopedPeristent<v8::
62 RefPtr<ClientRect> m_rect; 81 friend class RefCounted<ScriptFunction>;
63 }; 82 };
64 83
65 } // namespace WebCore 84 } // namespace WebCore
66 85
67 #endif 86 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698