Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: LayoutTests/http/tests/workers/worker-importScripts-onerror-sameorigin.html

Issue 22467005: Correctly attribute exceptions thrown inside a Worker's imported scripts. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Killing windows-specific expectations. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/workers/worker-importScripts-onerror-sameorigin.html
diff --git a/LayoutTests/http/tests/workers/worker-importScripts-onerror-sameorigin.html b/LayoutTests/http/tests/workers/worker-importScripts-onerror-sameorigin.html
index 18e96309093ee95c0bd30374863ef60e88a0276b..b3a2ef35654c5957029e25bf910fbe4154f77fcb 100644
--- a/LayoutTests/http/tests/workers/worker-importScripts-onerror-sameorigin.html
+++ b/LayoutTests/http/tests/workers/worker-importScripts-onerror-sameorigin.html
@@ -18,19 +18,20 @@
worker.onmessage = function (e) {
workerOnerror = e.data;
shouldBeEqualToString("workerOnerror.message", "Uncaught This is a custom error message.");
- shouldBeEqualToString("workerOnerror.filename", "http://127.0.0.1:8000/workers/resources/worker-importscripts-onerror-sameorigin.js");
- shouldEvaluateTo("workerOnerror.lineno", 5);
- shouldEvaluateTo("workerOnerror.column", 0);
+ shouldBeEqualToString("workerOnerror.filename", "http://127.0.0.1:8000/workers/resources/worker-importScripts-throw.js");
+ shouldEvaluateTo("workerOnerror.lineno", 1);
+ shouldEvaluateTo("workerOnerror.colno", 0);
+ shouldBeNull("workerOnerror.error");
};
var onerrorMessage, onerrorURL, onerrorLine;
worker.onerror = function (e) {
- onerrorMessage = e.message;
- onerrorURL = e.filename;
- onerrorLine = e.lineno;
- shouldBeEqualToString("onerrorMessage", "Uncaught This is a custom error message.");
- shouldBeEqualToString("onerrorURL", "http://127.0.0.1:8000/workers/resources/worker-importscripts-onerror-sameorigin.js");
- shouldEvaluateTo("onerrorLine", 5);
+ pageOnerror = e;
+ shouldBeEqualToString("pageOnerror.message", "Uncaught This is a custom error message.");
+ shouldBeEqualToString("pageOnerror.filename", "http://127.0.0.1:8000/workers/resources/worker-importScripts-throw.js");
+ shouldEvaluateTo("pageOnerror.lineno", 1);
+ shouldEvaluateTo("pageOnerror.colno", 0);
+ shouldBeNull("pageOnerror.error");
e.preventDefault();
finishJSTest();

Powered by Google App Engine
This is Rietveld 408576698