Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 22456003: [Andriod] Fixes monkey command line (Closed)

Created:
7 years, 4 months ago by gkanwar1
Modified:
7 years, 4 months ago
Reviewers:
craigdh, frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Andriod] Fixes monkey command line Adds example, usage, and changes default activity name to use the ContentShell activity. NOTRY=True BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216501

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixes command line nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M build/android/test_runner.py View 1 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gkanwar1
ptal
7 years, 4 months ago (2013-08-08 01:21:11 UTC) #1
frankf
lgtm w/ nit https://codereview.chromium.org/22456003/diff/1/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/22456003/diff/1/build/android/test_runner.py#newcode365 build/android/test_runner.py:365: ' --activity-name=org.chromium.content_shell_apk.ContentShellActivity') You can just use ...
7 years, 4 months ago (2013-08-08 01:26:12 UTC) #2
gkanwar1
https://codereview.chromium.org/22456003/diff/1/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/22456003/diff/1/build/android/test_runner.py#newcode365 build/android/test_runner.py:365: ' --activity-name=org.chromium.content_shell_apk.ContentShellActivity') On 2013/08/08 01:26:12, frankf wrote: > You ...
7 years, 4 months ago (2013-08-08 01:33:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/22456003/9001
7 years, 4 months ago (2013-08-08 21:06:11 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-09 00:07:15 UTC) #5
Message was sent while issue was closed.
Change committed as 216501

Powered by Google App Engine
This is Rietveld 408576698