Issue 22455002: linux_aura: Implement the static part of the dbus menu for Unity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22455002: linux_aura: Implement the static part of the dbus menu for Unity. (Closed)

Created:
7 years, 4 months ago by Elliot Glaysher

Modified:
7 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

linux_aura: Implement the static part of the dbus menu for Unity. [Relands r215769, which was reverted in r215780. It passed trybots and was landed by the CQ, and broke some chromeos configuration. This just adds gyp exclude rules for the new files.] BUG=265560 TBR=sky@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215928

Patch Set 1 #

Patch Set 2 : The gyp fix #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1119 lines, -294 lines)			Patch
M	chrome/browser/ui/views/frame/browser_desktop_root_window_host_x11.h	View		3 chunks	+16 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_desktop_root_window_host_x11.cc	View		3 chunks	+30 lines, -5 lines	0 comments	Download
A	chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.h	View		1 chunk	+54 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc	View		1 chunk	+139 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/frame/global_menu_bar_x11.h	View		1 chunk	+106 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/frame/global_menu_bar_x11.cc	View		1 chunk	+420 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1	3 chunks	+11 lines, -2 lines	0 comments	Download
A	ui/views/widget/desktop_aura/desktop_root_window_host_observer_x11.h	View		1 chunk	+29 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_root_window_host_x11.h	View		5 chunks	+41 lines, -33 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc	View		7 chunks	+273 lines, -252 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/22455002/2

7 years, 4 months ago (2013-08-06 17:54:47 UTC) #1

Message was sent while issue was closed.

Change committed as 215928

Expand Messages | Collapse Messages