Issue 22453006: Fixed calls to JS side from the UpdateScreen.

Issue 22453006: Fixed calls to JS side from the UpdateScreen. (Closed)

Created:
7 years, 4 months ago by ygorshenin1

Modified:
7 years, 4 months ago

Reviewers:
dzhioev (left Google)

CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed calls to JS side from the UpdateScreen. BUG=270297 TEST=Manual tests on Lumpy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217016

Patch Set 2 : Deleted stub methods from login.js #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -91 lines)			Patch
M	chrome/browser/resources/chromeos/login/login.js	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.js	View		1 chunk	+0 lines, -75 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe_screen_update.js	View		2 chunks	+83 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc	View		3 chunks	+8 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dzhioev (left Google)

https://codereview.chromium.org/22453006/diff/1/chrome/browser/resources/chromeos/login/oobe.js File chrome/browser/resources/chromeos/login/oobe.js (left): https://codereview.chromium.org/22453006/diff/1/chrome/browser/resources/chromeos/login/oobe.js#oldcode187 chrome/browser/resources/chromeos/login/oobe.js:187: setUpdateProgress: function(progress) { You can also remove corresponding dummy ...

7 years, 4 months ago (2013-08-12 09:11:01 UTC) #2

dzhioev (left Google)

LGTM with nit https://codereview.chromium.org/22453006/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_update.js File chrome/browser/resources/chromeos/login/oobe_screen_update.js (left): https://codereview.chromium.org/22453006/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_update.js#oldcode43 chrome/browser/resources/chromeos/login/oobe_screen_update.js:43: Bring back new line.

7 years, 4 months ago (2013-08-12 09:18:09 UTC) #3

ygorshenin1

Many thanks! https://codereview.chromium.org/22453006/diff/1/chrome/browser/resources/chromeos/login/oobe.js File chrome/browser/resources/chromeos/login/oobe.js (left): https://codereview.chromium.org/22453006/diff/1/chrome/browser/resources/chromeos/login/oobe.js#oldcode187 chrome/browser/resources/chromeos/login/oobe.js:187: setUpdateProgress: function(progress) { On 2013/08/12 09:11:01, dzhioev ...

7 years, 4 months ago (2013-08-12 09:37:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/22453006/7001

7 years, 4 months ago (2013-08-12 09:37:37 UTC) #5

Message was sent while issue was closed.

Change committed as 217016

Expand Messages | Collapse Messages