Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(54)

Issue 22451003: Enable Quickoffice Editor by default. (Closed)

Created:
7 years ago by dusk
Modified:
7 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Enable Quickoffice Editor by default. Flipped the existing About:flag around such that edting is enabled by default, and the flag is used to return to a regular vewier. Made the manifest naming clearer so its easier to see what is what. In updating the manifest have set the version number of the component extension to be correct. This replaces the original CL from dpolukhin which was posted at https://codereview.chromium.org/21629003/ BUG=264578 TEST=manual Change-Id: Ib614b863c7d231dae5958505c0d66a86d6d4bc94 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -212 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/resources/quick_office/manifest.json View 1 chunk +0 lines, -79 lines 0 comments Download
A + chrome/browser/resources/quick_office/manifest_editor.json View 4 chunks +25 lines, -19 lines 0 comments Download
D chrome/browser/resources/quick_office/manifest_experimental.json View 1 chunk +0 lines, -80 lines 0 comments Download
A + chrome/browser/resources/quick_office/manifest_viewing.json View 4 chunks +23 lines, -17 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
zel
lgtm
7 years ago (2013-08-06 20:19:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dskelton@chromium.org/22451003/1
7 years ago (2013-08-06 20:22:00 UTC) #2
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=19108
7 years ago (2013-08-06 20:31:16 UTC) #3
James Hawkins
lgtm
7 years ago (2013-08-06 20:43:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dskelton@chromium.org/22451003/1
7 years ago (2013-08-06 20:46:01 UTC) #5
commit-bot: I haz the power
7 years ago (2013-08-06 23:10:50 UTC) #6
Message was sent while issue was closed.
Change committed as 216017

Powered by Google App Engine
This is Rietveld 408576698