Second attempt at adding archive_layout_test_results to the blink trybots.

Second attempt at adding archive_layout_test_results to the blink trybots.

Now with gs_bucket.

R=dpranke@chromium.org
BUG=267102
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=215987

[iannucci, 2013-08-06 21:29:54]

PTAL

PS#1 is original, PS#2 is delta.

[Dirk Pranke, 2013-08-06 21:40:03]

lgtm.

https://codereview.chromium.org/22449006/diff/3001/scripts/slave/chromium/arc...
File scripts/slave/chromium/archive_layout_test_results.py (right):

https://codereview.chromium.org/22449006/diff/3001/scripts/slave/chromium/arc...
scripts/slave/chromium/archive_layout_test_results.py:149: gs_acl =
options.gs_acl
Do we actually need gs_acl ? I don't think we're currently using it, unless it's
getting passed implicitly from some other factory_property?

[iannucci, 2013-08-06 21:42:20]

On 2013/08/06 21:40:03, Dirk Pranke wrote:
> lgtm.
> 
>
https://codereview.chromium.org/22449006/diff/3001/scripts/slave/chromium/arc...
> File scripts/slave/chromium/archive_layout_test_results.py (right):
> 
>
https://codereview.chromium.org/22449006/diff/3001/scripts/slave/chromium/arc...
> scripts/slave/chromium/archive_layout_test_results.py:149: gs_acl =
> options.gs_acl
> Do we actually need gs_acl ? I don't think we're currently using it, unless
it's
> getting passed implicitly from some other factory_property?

We do routinely set both gs_bucket and gs_acl. On the layout bots we're not
passing it, and so on the blink bots we won't either. I added both flags since
they usually come in pairs with those names. If we do decide to add an acl, we
can just add a --gs-acl flag now (or alternately add it to factory properties)

[iannucci, 2013-08-06 21:44:30]

On 2013/08/06 21:42:20, iannucci wrote:
> On 2013/08/06 21:40:03, Dirk Pranke wrote:
> > lgtm.
> > 
> >
>
https://codereview.chromium.org/22449006/diff/3001/scripts/slave/chromium/arc...
> > File scripts/slave/chromium/archive_layout_test_results.py (right):
> > 
> >
>
https://codereview.chromium.org/22449006/diff/3001/scripts/slave/chromium/arc...
> > scripts/slave/chromium/archive_layout_test_results.py:149: gs_acl =
> > options.gs_acl
> > Do we actually need gs_acl ? I don't think we're currently using it, unless
> it's
> > getting passed implicitly from some other factory_property?
> 
> We do routinely set both gs_bucket and gs_acl. On the layout bots we're not
> passing it, and so on the blink bots we won't either. I added both flags since
> they usually come in pairs with those names. If we do decide to add an acl, we
> can just add a --gs-acl flag now (or alternately add it to factory properties)

(to be explicit: no, there are no factory properties being set on the blink
trybots other than recipe_name: blink_trybot, build_config: (Release|Debug), and
GIT_MODE: (True|False))

[commit-bot: I haz the power, 2013-08-06 21:46:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/22449006/3001

[commit-bot: I haz the power, 2013-08-06 21:47:45]

Change committed as 215987