Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 22447005: chromeos: Switch --first-boot to --first-exec-after-boot. (Closed)

Created:
7 years, 4 months ago by Daniel Erat
Modified:
7 years, 4 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Switch --first-boot to --first-exec-after-boot. The old flag was vaguely-named. The session manager is passing both flags now. BUG=none TBR=nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Daniel Erat
7 years, 4 months ago (2013-08-09 22:02:52 UTC) #1
Chris Masone
lgtm
7 years, 4 months ago (2013-08-09 22:04:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/22447005/1
7 years, 4 months ago (2013-08-09 22:06:10 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=19947
7 years, 4 months ago (2013-08-09 23:23:16 UTC) #4
Daniel Erat
TBR-ing Nikita for flag change in chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc.
7 years, 4 months ago (2013-08-10 00:02:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/22447005/1
7 years, 4 months ago (2013-08-10 00:07:18 UTC) #6
Nikita (slow)
lgtm
7 years, 4 months ago (2013-08-10 06:08:13 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-10 08:32:44 UTC) #8
Message was sent while issue was closed.
Change committed as 216830

Powered by Google App Engine
This is Rietveld 408576698