Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 22441006: [MC] Add the product name to the tray controller's title. (Closed)

Created:
7 years, 4 months ago by Robert Sesek
Modified:
7 years, 4 months ago
Reviewers:
dewittj
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

[MC] Add the product name to the tray controller's title. BUG=247814 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217045

Patch Set 1 #

Patch Set 2 : Move string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.mm View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ui/message_center/cocoa/tray_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/message_center/cocoa/tray_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/message_center/cocoa/tray_view_controller.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ui/message_center/cocoa/tray_view_controller.mm View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Robert Sesek
This is really more involved than I'd like, but because IDS_SHORT_PRODUCT_NAME is a chromium string, ...
7 years, 4 months ago (2013-08-08 20:47:42 UTC) #1
dewittj
I started writing a patch that took a different approach: put the string in google_chrome_strings.grd ...
7 years, 4 months ago (2013-08-08 21:09:39 UTC) #2
dewittj
code lgtm, if no preference about whether to use PRODUCT_NAME or to make our own ...
7 years, 4 months ago (2013-08-08 22:07:20 UTC) #3
Robert Sesek
On 2013/08/08 21:09:39, dewittj (OOO until Aug 20) wrote: > I started writing a patch ...
7 years, 4 months ago (2013-08-12 15:14:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/22441006/6001
7 years, 4 months ago (2013-08-12 16:35:56 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 19:06:45 UTC) #6
Message was sent while issue was closed.
Change committed as 217045

Powered by Google App Engine
This is Rietveld 408576698