Issue 22438003: Move SkComposeImageFilter into its own {.h, .cpp} files

Issue 22438003: Move SkComposeImageFilter into its own {.h, .cpp} files (Closed)

Created:
7 years, 4 months ago by ajuma

Modified:
7 years, 4 months ago

Reviewers:
Stephen White

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Move SkComposeImageFilter into its own {.h, .cpp} files In http://crrev.com/21154002, SkComposeImageFilter will be used outside of tests. Consequently, this moves SkComposeImageFilter from SkTestImageFilters.{h, cpp} into its own {.h, .cpp} files. BUG=181613 Committed: http://code.google.com/p/skia/source/detail?r=10591

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -68 lines)			Patch
M	gm/testimagefilters.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/effects.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	include/effects/SkComposeImageFilter.h	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	include/effects/SkTestImageFilters.h	View		1 chunk	+0 lines, -20 lines	0 comments	Download
A	src/effects/SkComposeImageFilter.cpp	View		1 chunk	+56 lines, -0 lines	0 comments	Download
M	src/effects/SkTestImageFilters.cpp	View		1 chunk	+0 lines, -48 lines	0 comments	Download
M	src/ports/SkGlobalInitialization_default.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Stephen White

LGTM https://chromiumcodereview.appspot.com/22438003/diff/1/include/effects/SkComposeImageFilter.h File include/effects/SkComposeImageFilter.h (right): https://chromiumcodereview.appspot.com/22438003/diff/1/include/effects/SkComposeImageFilter.h#newcode21 include/effects/SkComposeImageFilter.h:21: SkComposeImageFilter(SkFlattenableReadBuffer& buffer); Nit: explicit

7 years, 4 months ago (2013-08-06 19:50:07 UTC) #2

ajuma

https://chromiumcodereview.appspot.com/22438003/diff/1/include/effects/SkComposeImageFilter.h File include/effects/SkComposeImageFilter.h (right): https://chromiumcodereview.appspot.com/22438003/diff/1/include/effects/SkComposeImageFilter.h#newcode21 include/effects/SkComposeImageFilter.h:21: SkComposeImageFilter(SkFlattenableReadBuffer& buffer); On 2013/08/06 19:50:07, Stephen White wrote: > ...

7 years, 4 months ago (2013-08-06 20:09:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/ajuma@chromium.org/22438003/6001

7 years, 4 months ago (2013-08-06 20:09:52 UTC) #4

Message was sent while issue was closed.

Change committed as 10591

Expand Messages | Collapse Messages