chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java - Issue 2243423002: [Downloads] Add Incognito support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 2243423002: [Downloads] Add Incognito support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatting Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

index 20d19a4cb5b0e4ebbf2c8f673c31b4ad7396997c..bbe23fb6893794c7e2c5409ad817403ad6793ba1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

@@ -10,11 +10,9 @@ import android.view.Menu;

import android.view.MenuItem;

import org.chromium.base.ApiCompatibilityUtils;

-import org.chromium.base.CommandLine;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.ChromeFeatureList;

-import org.chromium.chrome.browser.ChromeSwitches;

import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.bookmarks.BookmarkBridge;

@@ -111,8 +109,7 @@ public class AppMenuPropertiesDelegate {

MenuItem offlineMenuItem = menu.findItem(R.id.offline_page_id);

if (offlineMenuItem != null) {

- if (CommandLine.getInstance().hasSwitch(

- ChromeSwitches.ENABLE_OFFLINE_PAGE_DOWNLOADING)) {

+ if (ChromeFeatureList.isEnabled("DownloadsUi")) {

offlineMenuItem.setEnabled(!isChromeScheme);

Drawable drawable = offlineMenuItem.getIcon();

if (drawable != null) {