Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java

Issue 2243423002: [Downloads] Add Incognito support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
index 09f820d02c26b47b4e969a1f98116ff591474242..d875a2c6a582e8eefaaa401643e52892bb28838e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
@@ -5,7 +5,9 @@
package org.chromium.chrome.browser.download;
import android.app.Activity;
+import android.content.Intent;
+import org.chromium.chrome.browser.IntentHandler;
import org.chromium.chrome.browser.UrlConstants;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.content_public.browser.LoadUrlParams;
@@ -23,7 +25,11 @@ public class DownloadUtils {
if (DeviceFormFactor.isTablet(activity)) {
tab.loadUrl(new LoadUrlParams(UrlConstants.DOWNLOADS_URL));
} else {
- DownloadActivity.launch(activity);
+ Intent intent = new Intent();
+ intent.setClass(activity, DownloadActivity.class);
+ intent.putExtra(IntentHandler.EXTRA_PARENT_COMPONENT, activity.getComponentName());
+ intent.putExtra(IntentHandler.EXTRA_OPEN_NEW_INCOGNITO_TAB, tab.isIncognito());
Ian Wen 2016/08/15 23:17:27 Haha you are sneaky. It's a bit weird to use this
gone 2016/08/15 23:29:49 Yeah... I wasn't sure if it was worth adding yet a
+ activity.startActivity(intent);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698