[Downloads] Add Incognito support

chrome/browser/android/download/download_manager_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/download/download_manager_service.h"
 
 #include "base/android/jni_string.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
@@ skipping 97 matching lines @@
     const JavaParamRef<jstring>& jdownload_guid,
     bool is_off_the_record) {
   std::string download_guid = ConvertJavaStringToUTF8(env, jdownload_guid);
   if (is_history_query_complete_ || is_off_the_record)
     RemoveDownloadInternal(download_guid, is_off_the_record);
   else
     EnqueueDownloadAction(download_guid, REMOVE);
 }
 
 void DownloadManagerService::GetAllDownloads(JNIEnv* env,
-                                             const JavaParamRef<jobject>& obj) {
+                                             const JavaParamRef<jobject>& obj,
+                                             bool is_off_the_record) {
   if (is_history_query_complete_)
-    GetAllDownloadsInternal();
+    GetAllDownloadsInternal(is_off_the_record);
+  else if (is_off_the_record)
+    EnqueueDownloadAction(std::string(), INITIALIZE_OFF_THE_RECORD_UI);
   else
     EnqueueDownloadAction(std::string(), INITIALIZE_UI);
 }
 
-void DownloadManagerService::GetDownloadInfoFor(
-    JNIEnv* env,
-    jobject obj,
-    const JavaParamRef<jstring>& jdownload_guid,
-    bool is_off_the_record) {
-  // The UI shouldn't be able to request any info about a specific item until it
-  // has been initialized with the list of existing downloads.
-  DCHECK(is_history_query_complete_ || is_off_the_record);
-
+void DownloadManagerService::GetAllDownloadsInternal(bool is_off_the_record) {
   content::DownloadManager* manager = GetDownloadManager(is_off_the_record);
   if (java_ref_.is_null() || !manager)
     return;
 
-  // Search through the downloads for the entry with the given GUID.
-  content::DownloadManager::DownloadVector all_items;
-  manager->GetAllDownloads(&all_items);
-  std::string download_guid = ConvertJavaStringToUTF8(env, jdownload_guid);
-  for (auto item : all_items) {
-    if (item->GetGuid() != download_guid)
-      continue;
-
-    Java_DownloadManagerService_onDownloadItemUpdated(
-        env,
-        java_ref_.obj(),
-        ConvertUTF8ToJavaString(env, item->GetGuid()).obj(),
-        ConvertUTF8ToJavaString(
-            env, item->GetFileNameToReportUser().value()).obj(),
-        ConvertUTF8ToJavaString(
-            env, item->GetTargetFilePath().value()).obj(),
-        ConvertUTF8ToJavaString(env, item->GetTabUrl().spec()).obj(),
-        ConvertUTF8ToJavaString(env, item->GetMimeType()).obj(),
-        item->GetStartTime().ToJavaTime(),
-        item->GetTotalBytes());
-    break;
-  }
-}
-
-void DownloadManagerService::GetAllDownloadsInternal() {
-  content::DownloadManager* manager = GetDownloadManager(false);
-  if (java_ref_.is_null() || !manager)
-    return;
-
   content::DownloadManager::DownloadVector all_items;
   manager->GetAllDownloads(&all_items);
 
   // Create a Java array of all of the visible DownloadItems.
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> j_download_item_list =
       Java_DownloadManagerService_createDownloadItemList(env, java_ref_.obj());
 
   for (size_t i = 0; i < all_items.size(); i++) {
     content::DownloadItem* item = all_items[i];
     if (!ShouldShowDownloadItem(item))
       continue;
 
     Java_DownloadManagerService_addDownloadItemToList(
         env,
         java_ref_.obj(),
         j_download_item_list.obj(),
         ConvertUTF8ToJavaString(env, item->GetGuid()).obj(),
         ConvertUTF8ToJavaString(
             env, item->GetFileNameToReportUser().value()).obj(),
         ConvertUTF8ToJavaString(
             env, item->GetTargetFilePath().value()).obj(),
         ConvertUTF8ToJavaString(env, item->GetTabUrl().spec()).obj(),
         ConvertUTF8ToJavaString(env, item->GetMimeType()).obj(),
         item->GetStartTime().ToJavaTime(),
         item->GetTotalBytes());
   }
 
   Java_DownloadManagerService_onAllDownloadsRetrieved(
-      env, java_ref_.obj(), j_download_item_list.obj());
+      env, java_ref_.obj(), j_download_item_list.obj(), is_off_the_record);
 }
 
 
 void DownloadManagerService::CancelDownload(
     JNIEnv* env,
     jobject obj,
     const JavaParamRef<jstring>& jdownload_guid,
     bool is_off_the_record,
     bool is_notification_dismissed) {
   std::string download_guid = ConvertJavaStringToUTF8(env, jdownload_guid);
@@ skipping 17 matching lines @@
       case RESUME:
         ResumeDownloadInternal(download_guid, false);
         break;
       case PAUSE:
         PauseDownloadInternal(download_guid, false);
         break;
       case CANCEL:
         CancelDownloadInternal(download_guid, false);
         break;
       case INITIALIZE_UI:
-        GetAllDownloadsInternal();
+        GetAllDownloadsInternal(false);
+        break;
+      case INITIALIZE_OFF_THE_RECORD_UI:
+        GetAllDownloadsInternal(true);
         break;
       default:
         NOTREACHED();
         break;
     }
   }
   pending_actions_.clear();
 
   // Monitor all DownloadItems for changes.
   content::DownloadManager* manager = GetDownloadManager(false);
   if (manager)
     original_notifier_.reset(new AllDownloadItemNotifier(manager, this));
+
+  content::DownloadManager* off_the_record_manager = GetDownloadManager(true);
+  if (off_the_record_manager) {
+    off_the_record_notifier_.reset(
+        new AllDownloadItemNotifier(off_the_record_manager, this));
+  }
+}
+
+void DownloadManagerService::OnDownloadUpdated(
+    content::DownloadManager* manager, content::DownloadItem* item) {
+  // Ignore anything that isn't a completed download notification.
+  if (!item->IsDone() || java_ref_.is_null())
+    return;
+
+  bool is_off_the_record = false;
+  content::DownloadManager* off_the_record_manager = GetDownloadManager(true);

[qinmin, 2016/08/16 16:53:14]

Can we do this by checking the DownloadItem's BrowserContext rather than
comparing the DownloadManager pointers?

[gone, 2016/08/16 18:24:25]

Didn't work before, but seems to now.  Weird, but I'll take it.

+  if (off_the_record_manager && manager == off_the_record_manager)
+    is_off_the_record = true;
+
+  JNIEnv* env = base::android::AttachCurrentThread();
+  Java_DownloadManagerService_onDownloadItemUpdated(
+      env,
+      java_ref_.obj(),
+      ConvertUTF8ToJavaString(env, item->GetGuid()).obj(),
+      ConvertUTF8ToJavaString(
+          env, item->GetFileNameToReportUser().value()).obj(),
+      ConvertUTF8ToJavaString(
+          env, item->GetTargetFilePath().value()).obj(),
+      ConvertUTF8ToJavaString(env, item->GetTabUrl().spec()).obj(),
+      ConvertUTF8ToJavaString(env, item->GetMimeType()).obj(),
+      item->GetStartTime().ToJavaTime(),
+      item->GetTotalBytes(),
+      is_off_the_record);
 }
 
 void DownloadManagerService::OnDownloadRemoved(
     content::DownloadManager* manager, content::DownloadItem* item) {
+  bool is_off_the_record = false;
+  content::DownloadManager* off_the_record_manager = GetDownloadManager(true);

[qinmin, 2016/08/16 16:53:14]

ditto

[gone, 2016/08/16 18:24:25]

Done.

+  if (off_the_record_manager && manager == off_the_record_manager)
+    is_off_the_record = true;
+
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_DownloadManagerService_onDownloadItemRemoved(
       env,
       java_ref_.obj(),
-      ConvertUTF8ToJavaString(env, item->GetGuid()).obj());
+      ConvertUTF8ToJavaString(env, item->GetGuid()).obj(),
+      is_off_the_record);
 }
 
 void DownloadManagerService::ResumeDownloadInternal(
     const std::string& download_guid, bool is_off_the_record) {
   content::DownloadManager* manager = GetDownloadManager(is_off_the_record);
   if (!manager) {
     OnResumptionFailed(download_guid);
     return;
   }
   content::DownloadItem* item = manager->GetDownloadByGuid(download_guid);
@@ skipping 62 matching lines @@
       if (iter->second == RESUME)
         iter->second = action;
       break;
     case CANCEL:
       iter->second = action;
       break;
     case REMOVE:
       iter->second = action;
       break;
     case INITIALIZE_UI:
+    case INITIALIZE_OFF_THE_RECORD_UI:
       iter->second = action;
       break;
     default:
       NOTREACHED();
       break;
   }
 }
 
 void DownloadManagerService::OnResumptionFailed(
     const std::string& download_guid) {
@@ skipping 16 matching lines @@
     resume_callback_for_testing_.Run(false);
 }
 
 content::DownloadManager* DownloadManagerService::GetDownloadManager(
     bool is_off_the_record) {
   Profile* profile = ProfileManager::GetActiveUserProfile();
   if (is_off_the_record)
     profile = profile->GetOffTheRecordProfile();
   return content::BrowserContext::GetDownloadManager(profile);
 }