Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 22430012: Web MIDI: implement WebMIDIClientMock to emulate permission handling for testing (Closed)

Created:
7 years, 4 months ago by Takashi Toyoshima
Modified:
7 years, 4 months ago
CC:
blink-reviews, jeez, dglazkov+blink, eae+blinkwatch, jamesr, abarth-chromium
Visibility:
Public.

Description

Web MIDI: implement WebMIDIClientMock to emulate permission handling for testing BUG=163795 TEST=LayoutTests/webmidi/permission.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156143

Patch Set 1 #

Patch Set 2 : works #

Patch Set 3 : cleanup #

Total comments: 6

Patch Set 4 : (rebase: similarity 85) #

Total comments: 1

Patch Set 5 : review #2 #

Patch Set 6 : web.gypi should not contain WebMIDIClientMock.h #

Patch Set 7 : (rebase of another test was needed) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -149 lines) Patch
A LayoutTests/webmidi/permission.html View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
A LayoutTests/webmidi/permission-expected.txt View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M LayoutTests/webmidi/requestmidiaccess-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/platform/mock/GeolocationClientMock.h View 1 chunk +7 lines, -7 lines 0 comments Download
A Source/core/platform/mock/MIDIClientMock.h View 1 chunk +56 lines, -0 lines 0 comments Download
A Source/core/platform/mock/MIDIClientMock.cpp View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
M Source/testing/runner/TestRunner.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/testing/runner/TestRunner.cpp View 1 3 chunks +12 lines, -0 lines 0 comments Download
M Source/testing/runner/WebTestProxy.cpp View 1 4 chunks +15 lines, -0 lines 0 comments Download
D Source/web/MIDIClientImpl.h View 1 1 chunk +0 lines, -60 lines 0 comments Download
D Source/web/MIDIClientImpl.cpp View 1 1 chunk +0 lines, -64 lines 0 comments Download
A + Source/web/MIDIClientProxy.h View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
A + Source/web/MIDIClientProxy.cpp View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
A Source/web/WebMIDIClientMock.cpp View 1 1 chunk +75 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 3 chunks +3 lines, -2 lines 0 comments Download
M Source/web/web.gypi View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M public/testing/WebTestProxy.h View 1 5 chunks +9 lines, -0 lines 0 comments Download
A public/web/WebMIDIClientMock.h View 1 chunk +66 lines, -0 lines 0 comments Download
M public/web/WebMIDIPermissionRequest.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Takashi Toyoshima
Hi Jochen, Thank you for your advice to implement this mock. Can take a look?
7 years, 4 months ago (2013-08-13 11:06:25 UTC) #1
jochen (gone - plz use gerrit)
https://chromiumcodereview.appspot.com/22430012/diff/6001/Source/core/platform/mock/GeolocationClientMock.h File Source/core/platform/mock/GeolocationClientMock.h (right): https://chromiumcodereview.appspot.com/22430012/diff/6001/Source/core/platform/mock/GeolocationClientMock.h#newcode63 Source/core/platform/mock/GeolocationClientMock.h:63: virtual void geolocationDestroyed() OVERRIDE; unrelated to this change? https://chromiumcodereview.appspot.com/22430012/diff/6001/Source/core/platform/mock/MIDIClientMock.cpp ...
7 years, 4 months ago (2013-08-13 13:27:12 UTC) #2
Takashi Toyoshima
https://chromiumcodereview.appspot.com/22430012/diff/6001/Source/core/platform/mock/GeolocationClientMock.h File Source/core/platform/mock/GeolocationClientMock.h (right): https://chromiumcodereview.appspot.com/22430012/diff/6001/Source/core/platform/mock/GeolocationClientMock.h#newcode63 Source/core/platform/mock/GeolocationClientMock.h:63: virtual void geolocationDestroyed() OVERRIDE; Actually, yes. But, I notice ...
7 years, 4 months ago (2013-08-13 15:48:23 UTC) #3
jochen (gone - plz use gerrit)
On 2013/08/13 15:48:23, Takashi Toyoshima (chromium) wrote: > https://chromiumcodereview.appspot.com/22430012/diff/6001/Source/core/platform/mock/GeolocationClientMock.h > File Source/core/platform/mock/GeolocationClientMock.h (right): > > ...
7 years, 4 months ago (2013-08-13 18:23:19 UTC) #4
Takashi Toyoshima
I followed the geolocation API style. I feel renaming it from *Impl to *Proxy and ...
7 years, 4 months ago (2013-08-13 23:12:11 UTC) #5
Takashi Toyoshima
To clarify what I did around MIDIClientImpl and MDIClientProxy, I optimized the similarity parameter so ...
7 years, 4 months ago (2013-08-14 02:03:50 UTC) #6
Takashi Toyoshima
s/review side/review site/
7 years, 4 months ago (2013-08-14 02:04:24 UTC) #7
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-14 12:03:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/22430012/23001
7 years, 4 months ago (2013-08-14 12:48:56 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=8091
7 years, 4 months ago (2013-08-14 13:27:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/22430012/38001
7 years, 4 months ago (2013-08-14 13:42:10 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=2011
7 years, 4 months ago (2013-08-14 15:28:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/22430012/42001
7 years, 4 months ago (2013-08-15 04:38:57 UTC) #13
commit-bot: I haz the power
7 years, 4 months ago (2013-08-15 06:31:01 UTC) #14
Message was sent while issue was closed.
Change committed as 156143

Powered by Google App Engine
This is Rietveld 408576698