Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 22430003: Enables (temporarily) adb trace for sharded perf tests. (Closed)

Created:
7 years, 4 months ago by bulach
Modified:
7 years, 4 months ago
Reviewers:
navabi1, frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Enables (temporarily) adb trace for sharded perf tests. This may help track down some issues with adb reliability: - sharder: sets the env var that will be inherited by the child shards. - run_command.py: redirect stderr (i.e., trace output) to stdout, otherwise higher up layers get confused with the extra data. It will be reverted soon after the data has been collected. BUG=268450 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216168

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M build/android/bb_run_sharded_steps.py View 2 chunks +13 lines, -0 lines 0 comments Download
M third_party/android_testrunner/run_command.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bulach
this patch will self-destroy soon :) ptal.
7 years, 4 months ago (2013-08-06 15:23:18 UTC) #1
frankf
oh, the noise :) lgtm
7 years, 4 months ago (2013-08-06 18:07:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/22430003/3001
7 years, 4 months ago (2013-08-07 09:20:09 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-07 12:45:29 UTC) #4
Message was sent while issue was closed.
Change committed as 216168

Powered by Google App Engine
This is Rietveld 408576698