Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 22418006: effects: Replaces uses of GrAssert with SkASSERT. (Closed)

Created:
7 years, 4 months ago by tfarina
Modified:
7 years, 4 months ago
CC:
skia-review_googlegroups.com, robertphillips
Visibility:
Public.

Description

effects: Replaces uses of GrAssert with SkASSERT. This is the first step on migrating from GrAssert to SkASSERT as requested by Brian. R=bsalomon@google.com Committed: http://code.google.com/p/skia/source/detail?r=10706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M src/effects/SkArithmeticMode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
Sorry, just boring, trivial, search and replace work, nothing really exciting to see/review. ptal, thanks.
7 years, 4 months ago (2013-08-11 14:18:50 UTC) #1
robertphillips
lgtm
7 years, 4 months ago (2013-08-12 11:49:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/22418006/1
7 years, 4 months ago (2013-08-13 01:35:01 UTC) #3
tfarina
Leon, can I land this? The tree is still closed.
7 years, 4 months ago (2013-08-13 22:28:33 UTC) #4
commit-bot: I haz the power
List of reviewers changed. scroggo@google.com did a drive-by without LGTM'ing!
7 years, 4 months ago (2013-08-14 11:36:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/22418006/1
7 years, 4 months ago (2013-08-14 12:08:43 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-14 12:09:05 UTC) #7
Message was sent while issue was closed.
Change committed as 10706

Powered by Google App Engine
This is Rietveld 408576698