Issue 22413002: Try UTF-8 encoding first for XHR postData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22413002: Try UTF-8 encoding first for XHR postData. (Closed)

Created:
7 years, 4 months ago by eustas

Modified:
7 years, 4 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Assume: xhr.open("POST", "?q"); xhr.send(payload); User expects that data shown in NetworkPanel is the same as "payload". When payload contains non-ASCII chars, this is not true. That is because postData is decoded with Latin-1 codec. BUG=136170 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155937

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -2 lines)			Patch
A	LayoutTests/http/tests/inspector/network/network-xhr-post-payload.html	View	1 chunk	+33 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/inspector/network/network-xhr-post-payload-expected.txt	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorResourceAgent.cpp	View	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/22413002/1

7 years, 4 months ago (2013-08-12 13:30:57 UTC) #3

Message was sent while issue was closed.

Change committed as 155937

Expand Messages | Collapse Messages