Fix scoped of closer for ACK for editor-related changes.

Fix scoped of closer for  ACK for editor-related changes.

Sending the ACK for for editor-related changes not originating from
browser uses a ScopedClosureRunner. However, since this was defined
within an if-block, the scope ended immediately.

This changes it to have a scope of the whole method, and instead
releasing it early if we are not supposed to send the ACK.

BUG=145521, 230848, 172845, 248544, 235704
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216853

[nyquist, 2013-08-09 00:16:40]

cjhopman: PTAL

[cjhopman, 2013-08-09 00:20:35]

lgtm w/ nit

https://codereview.chromium.org/22411008/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/22411008/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_android.cc:411: if
(!params.require_ack) ack_caller.Release();
Nit: add a break after condition

[nyquist, 2013-08-09 00:24:50]

sievers: PTAL for OWNERS

[no sievers, 2013-08-09 00:32:12]

On 2013/08/09 00:24:50, nyquist wrote:
> sievers: PTAL for OWNERS

lgtm. remove the ifdef OS_ANDROID?

[commit-bot: I haz the power, 2013-08-09 16:23:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/22411008/6001

[nyquist, 2013-08-09 16:24:17]

We might looking into doing this for other platforms later, but for now, this
new way of handling IME is only done on Android.

[no sievers, 2013-08-09 16:41:37]

On 2013/08/09 16:24:17, nyquist wrote:
> We might looking into doing this for other platforms later, but for now, this
> new way of handling IME is only done on Android.

You are inside a source file that is only compiled on Android ;)

content/browser/renderer_host/render_widget_host_view_android.cc

[nyquist, 2013-08-09 18:05:28]

On 2013/08/09 16:41:37, sievers wrote:
> On 2013/08/09 16:24:17, nyquist wrote:
> > We might looking into doing this for other platforms later, but for now,
this
> > new way of handling IME is only done on Android.
> 
> You are inside a source file that is only compiled on Android ;)
> 
> content/browser/renderer_host/render_widget_host_view_android.cc

Doh! I will do that in a follow up at some point.

[commit-bot: I haz the power, 2013-08-09 20:19:42]

Failed to trigger a try job on win_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-08-09 20:21:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/22411008/32001

[commit-bot: I haz the power, 2013-08-10 04:00:53]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-08-10 04:20:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/22411008/32001

[commit-bot: I haz the power, 2013-08-10 14:20:09]

Change committed as 216853